cluster: validate topo changes after edit-config #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AstroProfundis
added
type/new-feature
AstroProfundis
force-pushed
the
edit-config-validate
branch
2 times, most recently
from
7f6e6f9 to
eaad121
Compare
Codecov Report
@@ Coverage Diff @@
## master #609 +/- ##
==========================================
+ Coverage 51.20% 51.34% +0.14%
==========================================
Files 225 225
Lines 16573 16593 +20
==========================================
+ Hits 8486 8520 +34
+ Misses 6901 6888 -13
+ Partials 1186 1185 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
AstroProfundis
force-pushed
the
edit-config-validate
branch
from
eaad121 to
4b47b8b
Compare
lonng
reviewed
Jul 21, 2020
lonng
reviewed
Jul 21, 2020
pkg/cluster/edit/diff.go
Outdated
| pathEditable := true | ||
| pathIgnore := false | ||
| for _, p := range c.Path { | ||
| if _, err := strconv.Atoi(p); err == nil { |
There was a problem hiding this comment.
I think we cannot ignore the slice, for example, user add a new host into tidb_servers.
There was a problem hiding this comment.
tidb_servers is not ignored, server_configs.tidb is.
lonng
reviewed
Jul 21, 2020
pkg/cluster/edit/diff.go
Outdated
| continue | ||
| } | ||
| } | ||
| msg = append(msg, fmt.Sprintf("(%s) %s '%v' -> '%v'", c.Type, strings.Join(c.Path, "."), c.From, c.To)) |
There was a problem hiding this comment.
I think we should generate more readable error message. e.g:
- update:
cannot change the xxx field from 1 to 2 - delete:
cannot delete the field xxx - create:
cannot add the field xxx into yyy
AstroProfundis
force-pushed
the
edit-config-validate
branch
from
4b47b8b to
2c2e8b8
Compare
AstroProfundis
force-pushed
the
edit-config-validate
branch
from
2c2e8b8 to
76aa890
Compare
lonng
approved these changes
Jul 21, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
add validation for topology diff to forbid changes of immutable fields
Check List
Tests
Code changes
Side effects
Related changes