Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: optimize tispark supporting #621

Merged
merged 3 commits into from
Jul 22, 2020

Conversation

AstroProfundis
Copy link
Contributor

Close: #617

@AstroProfundis AstroProfundis added type/enhancement Categorizes issue or PR as related to an enhancement. category/usability Categorizes issue or PR as a usability enhancement. labels Jul 22, 2020
@AstroProfundis AstroProfundis requested review from lonng and lucklove July 22, 2020 07:35
@AstroProfundis AstroProfundis self-assigned this Jul 22, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2020

Codecov Report

Merging #621 into master will decrease coverage by 3.39%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #621      +/-   ##
==========================================
- Coverage   51.33%   47.93%   -3.40%     
==========================================
  Files         225      225              
  Lines       16669    16685      +16     
==========================================
- Hits         8557     7998     -559     
- Misses       6926     7570     +644     
+ Partials     1186     1117      -69     
Flag Coverage Δ
#coverage 47.93% <ø> (-3.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...b.com/pingcap/tiup/pkg/cluster/task/update_meta.go 0.00% <0.00%> (-74.20%) ⬇️
...com/pingcap/tiup/pkg/cluster/operation/scale_in.go 0.00% <0.00%> (-56.80%) ⬇️
...ngcap/tiup/components/cluster/command/scale_out.go 9.09% <0.00%> (-55.42%) ⬇️
....com/pingcap/tiup/pkg/cluster/task/scale_config.go 0.00% <0.00%> (-53.85%) ⬇️
...ingcap/tiup/components/cluster/command/scale_in.go 9.09% <0.00%> (-49.50%) ⬇️
.../github.com/pingcap/tiup/pkg/cluster/api/binlog.go 0.00% <0.00%> (-45.20%) ⬇️
...c/github.com/pingcap/tiup/pkg/cluster/task/func.go 0.00% <0.00%> (-40.00%) ⬇️
...om/pingcap/tiup/pkg/cluster/template/scripts/pd.go 40.47% <0.00%> (-29.77%) ⬇️
...cap/tiup/pkg/cluster/clusterutil/parse_topology.go 33.33% <0.00%> (-28.58%) ⬇️
...git.luolix.top/pingcap/tiup/pkg/colorutil/colorutil.go 65.51% <0.00%> (-13.80%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 319683e...f885bc8. Read the comment docs.

pkg/cluster/spec/spec.go Outdated Show resolved Hide resolved
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 22, 2020
@lonng lonng merged commit e722847 into pingcap:master Jul 22, 2020
@AstroProfundis AstroProfundis deleted the optimize-tispark branch July 22, 2020 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/usability Categorizes issue or PR as a usability enhancement. status/LGT1 Indicates that a PR has LGTM 1. type/enhancement Categorizes issue or PR as related to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misc adjustments of TiSpark support
4 participants