Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh monitor configs on reload #630

Merged
merged 3 commits into from
Jul 27, 2020
Merged

Conversation

lucklove
Copy link
Member

Fix #628

Signed-off-by: lucklove gnu.crazier@gmail.com

Fix pingcap#628

Signed-off-by: lucklove <gnu.crazier@gmail.com>
@lucklove lucklove requested a review from lonng July 24, 2020 12:30
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2020

Codecov Report

Merging #630 into master will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #630      +/-   ##
==========================================
+ Coverage   47.74%   47.96%   +0.21%     
==========================================
  Files         225      225              
  Lines       16749    16786      +37     
==========================================
+ Hits         7997     8051      +54     
+ Misses       7630     7609      -21     
- Partials     1122     1126       +4     
Flag Coverage Δ
#coverage 47.96% <ø> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/github.com/pingcap/tiup/pkg/cluster/api/pdapi.go 52.17% <0.00%> (-1.25%) ⬇️
...m/pingcap/tiup/components/playground/playground.go 30.17% <0.00%> (+0.96%) ⬆️
.../pingcap/tiup/components/cluster/command/reload.go 72.51% <0.00%> (+10.81%) ⬆️
.../pingcap/tiup/components/playground/utils/utils.go 31.91% <0.00%> (+31.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f00092f...11bd646. Read the comment docs.

@lonng lonng added the type/bug-fix Categorizes PR as a bug-fix label Jul 27, 2020
@lonng lonng added this to the v1.1.0 milestone Jul 27, 2020
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Co-authored-by: Lonng <heng@lonng.org>
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 27, 2020
@lucklove lucklove merged commit 3baffa1 into pingcap:master Jul 27, 2020
@lucklove lucklove deleted the monitor-systemd branch July 27, 2020 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT1 Indicates that a PR has LGTM 1. type/bug-fix Categorizes PR as a bug-fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monitor components systemd service file doesn't be generated when reload
4 participants