Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update source file format #655

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Update source file format #655

merged 1 commit into from
Aug 5, 2020

Conversation

july2993
Copy link
Contributor

@july2993 july2993 commented Aug 5, 2020

Update source file format

dm has updated the file format form toml to yml

release note:

Support yml source format with tiup-dm

Copy link
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 5, 2020
@july2993 july2993 marked this pull request as ready for review August 5, 2020 07:39
@codecov-commenter
Copy link

Codecov Report

Merging #655 into master will increase coverage by 0.66%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #655      +/-   ##
==========================================
+ Coverage   56.71%   57.37%   +0.66%     
==========================================
  Files         242      243       +1     
  Lines       17469    17510      +41     
==========================================
+ Hits         9908    10047     +139     
+ Misses       6265     6164     -101     
- Partials     1296     1299       +3     
Flag Coverage Δ
#coverage 57.37% <ø> (+0.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/github.com/pingcap/tiup/pkg/cluster/spec/spec.go 90.94% <0.00%> (-2.62%) ⬇️
...m/pingcap/tiup/components/cluster/command/check.go 81.63% <0.00%> (-0.50%) ⬇️
...src/github.com/pingcap/tiup/pkg/cluster/manager.go 70.37% <0.00%> (-0.20%) ⬇️
....com/pingcap/tiup/pkg/cluster/spec/spec_manager.go 67.50% <0.00%> (-0.15%) ⬇️
...c/github.com/pingcap/tiup/pkg/cluster/api/dmapi.go 61.31% <0.00%> (ø)
....com/pingcap/tiup/pkg/cluster/operation/destroy.go 54.48% <0.00%> (ø)
...com/pingcap/tiup/pkg/cluster/spec/server_config.go 65.87% <0.00%> (ø)
....com/pingcap/tiup/pkg/cluster/clusterutil/retry.go
...ub.com/pingcap/tiup/pkg/cliutil/prepare/prepare.go
go/src/github.com/pingcap/tiup/pkg/utils/utils.go 100.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2461a3...b60aec7. Read the comment docs.

@lucklove lucklove merged commit 80da63c into pingcap:master Aug 5, 2020
@july2993 july2993 deleted the yml branch August 5, 2020 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants