Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add advertise-status-addr for tiflash proxy #676

Merged
merged 6 commits into from
Aug 14, 2020
Merged

Add advertise-status-addr for tiflash proxy #676

merged 6 commits into from
Aug 14, 2020

Conversation

birdstorm
Copy link
Contributor

What problem does this PR solve?

Add advertise-status-addr for tiflash to support host name.

Check List

Tests

  • No code

Release notes:

Add `advertise-status-addr` for tiflash to support host name

@CLAassistant
Copy link

CLAassistant commented Aug 12, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@birdstorm
Copy link
Contributor Author

@solotzg PTAL

solotzg
solotzg approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@solotzg solotzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot
Copy link
Contributor

@solotzg,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: tiup(slack).

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2020 •
edited
Loading

Codecov Report

Merging #676 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #676      +/-   ##
==========================================
- Coverage   57.53%   57.53%   -0.01%     
==========================================
  Files         250      250              
  Lines       17920    17932      +12     
==========================================
+ Hits        10311    10317       +6     
- Misses       6255     6258       +3     
- Partials     1354     1357       +3
Flag Coverage Δ
#coverage 57.53% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onents/playground/instance/tiflash_proxy_config.go 66.66% <0.00%> (-33.34%) ⬇️
go/src/github.com/pingcap/tiup/pkg/utils/ioutil.go 47.54% <0.00%> (-1.64%) ⬇️
...ithub.com/pingcap/tiup/pkg/cluster/spec/tiflash.go 64.03% <0.00%> (-0.75%) ⬇️
...c/github.com/pingcap/tiup/pkg/cluster/api/pdapi.go 58.53% <0.00%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fb628d...f9788d2. Read the comment docs.

solotzg
solotzg approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@solotzg solotzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot
Copy link
Contributor

@solotzg,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: tiup(slack).

@lonng lonng added the type/enhancement Categorizes issue or PR as related to an enhancement. label Aug 13, 2020
lonng
lonng reviewed Aug 13, 2020
View reviewed changes
pkg/cluster/spec/tiflash.go Outdated Show resolved Hide resolved
lonng
lonng approved these changes Aug 13, 2020
View reviewed changes
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 13, 2020
@birdstorm
Copy link
Contributor Author

@lonng PTAL again, thanks.

lonng
lonng approved these changes Aug 13, 2020
View reviewed changes
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lonng
Copy link
Contributor

lonng commented Aug 14, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 14, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit d156c6a into pingcap:master Aug 14, 2020
@birdstorm birdstorm deleted the enable-host-in-status-addr branch August 18, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@july2993 july2993 july2993 left review comments

@solotzg solotzg solotzg approved these changes

@lonng lonng lonng approved these changes

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/enhancement Categorizes issue or PR as related to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@birdstorm @CLAassistant @ti-srebot @codecov-commenter @lonng @july2993 @solotzg