Dump dns & port file at data dir #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Playground duump dsn&port file at wd. After we changed not to set wd as instance data dir, playground dump this file at wd but not instance data dir(not same dir like before). This broke playground subcommand and "tiup client", which search this files at ~/.tiup/data/../
july2993
requested review from
lonng and
lucklove
and removed request for
lonng
ti-srebot
approved these changes
Sep 3, 2020
Codecov Report
@@ Coverage Diff @@
## master #749 +/- ##
==========================================
+ Coverage 58.07% 58.79% +0.72%
==========================================
Files 255 257 +2
Lines 18904 19441 +537
==========================================
+ Hits 10978 11431 +453
- Misses 6473 6497 +24
- Partials 1453 1513 +60
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@july2993 merge failed. |
lucklove
pushed a commit
that referenced
this pull request
Sep 11, 2020
Playground duump dsn&port file at wd. After we changed not to set wd as instance data dir, playground dump this file at wd but not instance data dir(not same dir like before). This broke playground subcommand and "tiup client", which search this files at ~/.tiup/data/../
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Playground dump dsn&port file at wd.
After we changed not to set wd as instance data dir, playground dump
this file at wd but not instance data dir(not same dir like before).
This broke playground subcommand and "tiup client", which search this
files at ~/.tiup/data/../
What is changed and how it works?
Check List
Tests
Release notes: