Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependences version binding when cloning mirror #778

Closed
wants to merge 2 commits into from

Conversation

lonng
Copy link
Contributor

@lonng lonng commented Sep 13, 2020

Signed-off-by: Lonng heng@lonng.org

What problem does this PR solve?

Currently, if the versions of the non-core components not specified, the latest version will be chosen. The behavior will abort the tiup cluster deploy because it binds version to a specific version to tispark/spark.

This PR fixes dependences version binding when cloning mirrors.

Release notes:

Fix dependences version binding when cloning mirror

Signed-off-by: Lonng <heng@lonng.org>
@lonng lonng added the type/bug-fix Categorizes PR as a bug-fix label Sep 13, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2020

Codecov Report

Merging #778 into master will decrease coverage by 0.78%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #778      +/-   ##
==========================================
- Coverage   54.71%   53.92%   -0.79%     
==========================================
  Files         260      260              
  Lines       21076    21080       +4     
==========================================
- Hits        11531    11367     -164     
- Misses       7991     8179     +188     
+ Partials     1554     1534      -20     
Flag Coverage Δ
#cluster 46.31% <20.00%> (-0.54%) ⬇️
#dm 26.44% <0.00%> (-0.50%) ⬇️
#integrate 49.19% <20.00%> (-0.80%) ⬇️
#playground 23.06% <0.00%> (-0.02%) ⬇️
#tiup 19.78% <0.00%> (-0.02%) ⬇️
#unittest 19.49% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/repository/clone_mirror.go 0.00% <0.00%> (ø)
pkg/cluster/spec/bindversion.go 86.95% <100.00%> (ø)
pkg/utils/utils.go 50.00% <0.00%> (-50.00%) ⬇️
pkg/cluster/executor/ssh.go 27.56% <0.00%> (-30.28%) ⬇️
pkg/cluster/template/scripts/pd.go 44.04% <0.00%> (-29.77%) ⬇️
pkg/utils/retry.go 32.55% <0.00%> (-16.28%) ⬇️
pkg/cluster/executor/executor.go 54.23% <0.00%> (-11.87%) ⬇️
pkg/cluster/spec/pd.go 58.38% <0.00%> (-10.99%) ⬇️
components/dm/command/scale_out.go 86.20% <0.00%> (-6.90%) ⬇️
pkg/cluster/task/update_meta.go 67.74% <0.00%> (-6.46%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 380be8f...7c7ee6e. Read the comment docs.

@lucklove
Copy link
Member

Close this since #779

@lucklove lucklove closed this Sep 13, 2020
@kaaaaaaang kaaaaaaang deleted the fix-mirror-clone branch April 25, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug-fix Categorizes PR as a bug-fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants