Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pingcap/go-tpc version #887

Merged
merged 2 commits into from
Nov 6, 2020
Merged

Conversation

mahjonp
Copy link
Contributor

@mahjonp mahjonp commented Nov 6, 2020

Signed-off-by: mahjonp junpeng.man@gmail.com

What problem does this PR solve?

fix #886

What is changed and how it works?

Ref: pingcap/go-tpc#63

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

Signed-off-by: mahjonp <junpeng.man@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Nov 6, 2020

CLA assistant check
All committers have signed the CLA.

Signed-off-by: mahjonp <junpeng.man@gmail.com>
Copy link
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 6, 2020
@codecov-io
Copy link

codecov-io commented Nov 6, 2020

Codecov Report

Merging #887 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #887      +/-   ##
==========================================
- Coverage   53.53%   53.47%   -0.06%     
==========================================
  Files         263      263              
  Lines       19067    19067              
==========================================
- Hits        10207    10197      -10     
- Misses       7288     7295       +7     
- Partials     1572     1575       +3     
Flag Coverage Δ
cluster 45.47% <ø> (-0.06%) ⬇️
dm 25.24% <ø> (-0.07%) ⬇️
integrate 48.31% <ø> (-0.06%) ⬇️
playground 22.28% <ø> (ø)
tiup 10.85% <ø> (ø)
unittest 21.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/spec/util.go 76.74% <0.00%> (-4.66%) ⬇️
pkg/cluster/template/scripts/pd.go 68.75% <0.00%> (-3.13%) ⬇️
pkg/cluster/spec/pd.go 68.51% <0.00%> (-2.47%) ⬇️
pkg/cluster/api/dmapi.go 58.26% <0.00%> (-1.74%) ⬇️
pkg/cluster/manager.go 67.85% <0.00%> (-0.15%) ⬇️
pkg/cluster/api/pdapi.go 61.91% <0.00%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d7cc25...3fcc440. Read the comment docs.

@lucklove lucklove merged commit cad0c4e into pingcap:master Nov 6, 2020
@lucklove lucklove added this to the v1.2.4 milestone Nov 19, 2020
lucklove pushed a commit that referenced this pull request Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

client has multi-statement capability disabled
5 participants