Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize TiKV --advertise-status-addr #951

Merged
merged 2 commits into from
Dec 3, 2020

Conversation

lucklove
Copy link
Member

What problem does this PR solve?

Fix #892

What is changed and how it works?

When init script for TiKV, check if current cluster version >= v4.0.1, if so, use --advertise-status-addr

Check List

Tests

  • Integration test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch

Release notes:

NONE

@ti-chi-bot ti-chi-bot requested a review from lonng November 30, 2020 10:14
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 30, 2020
@lucklove lucklove added this to the v1.2.6 milestone Nov 30, 2020
@codecov-io
Copy link

codecov-io commented Nov 30, 2020

Codecov Report

Merging #951 (791f648) into master (4e336b2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #951   +/-   ##
=======================================
  Coverage   55.81%   55.82%           
=======================================
  Files         263      263           
  Lines       19513    19515    +2     
=======================================
+ Hits        10892    10894    +2     
+ Misses       6894     6893    -1     
- Partials     1727     1728    +1     
Flag Coverage Δ
cluster 43.33% <100.00%> (+0.02%) ⬆️
dm 24.30% <11.11%> (-0.07%) ⬇️
integrate 50.03% <100.00%> (+<0.01%) ⬆️
playground 20.30% <ø> (+0.02%) ⬆️
tiup 16.82% <11.11%> (-0.01%) ⬇️
unittest 23.06% <11.11%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/embed/autogen_pkger.go 100.00% <100.00%> (ø)
pkg/cluster/spec/tikv.go 56.15% <100.00%> (+0.21%) ⬆️
pkg/cluster/template/scripts/tikv.go 76.47% <100.00%> (+0.71%) ⬆️
pkg/utils/http_client.go 66.66% <0.00%> (-5.56%) ⬇️
pkg/cluster/api/dmapi.go 58.26% <0.00%> (-1.74%) ⬇️
pkg/cluster/api/pdapi.go 60.37% <0.00%> (+1.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e336b2...791f648. Read the comment docs.

@lucklove
Copy link
Member Author

lucklove commented Dec 1, 2020

@breeswish PTAL

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 2, 2020
@lucklove lucklove merged commit a290d33 into pingcap:master Dec 3, 2020
@lucklove lucklove modified the milestones: v1.2.6, v1.3.0 Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Utilize TiKV --advertise-status-addr
4 participants