Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confirm in upgrade #963

Merged
merged 4 commits into from
Dec 8, 2020
Merged

Conversation

Win-Man
Copy link
Contributor

@Win-Man Win-Man commented Dec 2, 2020

What problem does this PR solve?

TiUP will upgrade the cluster directly without confirming when execute upgrade command. Upgrade is an important operation that requied confirm by the user.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
tiup cluster upgrade ${cluster-name} ${version}
  • No code

Code changes

  • Has exported function/method change

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release notes:

NONE

@ti-chi-bot ti-chi-bot requested a review from lonng December 2, 2020 11:21
@CLAassistant
Copy link

CLAassistant commented Dec 2, 2020

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 2, 2020
color.HiYellowString(clusterVersion)); err != nil {
return err
}
log.Infof("Destroying cluster...")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Destroying/Upgrading/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix it.

@codecov-io
Copy link

codecov-io commented Dec 8, 2020

Codecov Report

Merging #963 (e75ecff) into master (be3cfd5) will decrease coverage by 22.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #963       +/-   ##
===========================================
- Coverage   52.05%   29.95%   -22.10%     
===========================================
  Files         263      249       -14     
  Lines       19533    18199     -1334     
===========================================
- Hits        10167     5452     -4715     
- Misses       7722    11900     +4178     
+ Partials     1644      847      -797     
Flag Coverage Δ
cluster ?
dm ?
integrate 21.58% <ø> (-24.65%) ⬇️
playground 20.26% <ø> (ø)
tiup 16.79% <ø> (ø)
unittest 23.08% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/cluster/command/upgrade.go 42.85% <0.00%> (-42.86%) ⬇️
components/dm/command/upgrade.go 42.85% <0.00%> (-28.58%) ⬇️
pkg/cluster/manager.go 1.07% <0.00%> (-59.69%) ⬇️
pkg/meta/paths.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/utils/utils.go 0.00% <0.00%> (-100.00%) ⬇️
components/dm/main.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/prepare.go 0.00% <0.00%> (-100.00%) ⬇️
components/cluster/main.go 0.00% <0.00%> (-100.00%) ⬇️
components/dm/spec/bindversion.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/template/config/config.go 0.00% <0.00%> (-100.00%) ⬇️
... and 148 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be3cfd5...e75ecff. Read the comment docs.

@lucklove
Copy link
Member

lucklove commented Dec 8, 2020

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 8, 2020
@lucklove
Copy link
Member

lucklove commented Dec 8, 2020

/merge

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 8, 2020
@ti-chi-bot
Copy link
Member

Can merge label has been added.

Git tree hash: 4b8aded

@ti-chi-bot
Copy link
Member

@Win-Man: Your PR has out-of-dated and I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/ti-community-prow repository.

@ti-chi-bot ti-chi-bot merged commit efce389 into pingcap:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants