-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add confirm in upgrade #963
Conversation
pkg/cluster/manager.go
Outdated
color.HiYellowString(clusterVersion)); err != nil { | ||
return err | ||
} | ||
log.Infof("Destroying cluster...") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/Destroying/Upgrading/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix it.
Codecov Report
@@ Coverage Diff @@
## master #963 +/- ##
===========================================
- Coverage 52.05% 29.95% -22.10%
===========================================
Files 263 249 -14
Lines 19533 18199 -1334
===========================================
- Hits 10167 5452 -4715
- Misses 7722 11900 +4178
+ Partials 1644 847 -797
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/lgtm |
/merge |
Can merge label has been added. Git tree hash: 4b8aded
|
@Win-Man: Your PR has out-of-dated and I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/ti-community-prow repository. |
What problem does this PR solve?
TiUP will upgrade the cluster directly without confirming when execute upgrade command. Upgrade is an important operation that requied confirm by the user.
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: