cluster/clean: prompt list of paths to be delete before processing (part 2) #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AstroProfundis
added
type/enhancement
ti-chi-bot
added
the
size/L
AstroProfundis
changed the title
lucklove
reviewed
Dec 16, 2020
pkg/cluster/manager/cleanup.go
Outdated
| @@ -39,6 +44,44 @@ func (m *Manager) CleanCluster(name string, gOpt operator.Options, cleanOpt oper | |||
| return err | |||
| } | |||
|
|
|||
| // calculate file paths to be deleted before the prompt | |||
| delFileMaps := make(map[string]set.StringSet) | |||
|
rest lgtm |
Codecov Report
@@ Coverage Diff @@
## master #993 +/- ##
==========================================
- Coverage 55.48% 55.47% -0.01%
==========================================
Files 279 279
Lines 19709 19710 +1
==========================================
- Hits 10936 10935 -1
- Misses 7058 7062 +4
+ Partials 1715 1713 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
/lgtm |
|
/merge |
ti-chi-bot
added
the
status/can-merge
|
Can merge label has been added. Git tree hash: 4842c6f
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Prompt the user for file paths that are going to be delete and ask for confirmation, so that the user has a chance to cancel the process if there's anything unexpected.
This is a following up of #981 and closes #947
What is changed and how it works?
Calculate the file list before promoting for confirmation.
Check List
Tests
Code changes
Related changes
Release notes: