Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump v1.3.0 #998

Merged
merged 9 commits into from
Dec 18, 2020
Merged

Bump v1.3.0 #998

merged 9 commits into from
Dec 18, 2020

Conversation

lucklove
Copy link
Member

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 17, 2020
@codecov-io
Copy link

codecov-io commented Dec 17, 2020 •
edited
Loading

Codecov Report

Merging #998 (922ef95) into master (295ade4) will decrease coverage by 7.59%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #998      +/-   ##
==========================================
- Coverage   55.60%   48.00%   -7.60%     
==========================================
  Files         279      266      -13     
  Lines       19715    19263     -452     
==========================================
- Hits        10962     9247    -1715     
- Misses       7042     8505    +1463     
+ Partials     1711     1511     -200
Flag Coverage Δ
cluster 40.54% <ø> (-2.96%) ⬇️
dm ?
integrate 45.28% <ø> (-4.58%) ⬇️
playground ?
tiup 16.48% <ø> (ø)
unittest 23.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/version/version.go 84.61% <ø> (ø)
components/dm/main.go 0.00% <0.00%> (-100.00%) ⬇️
components/dm/spec/bindversion.go 0.00% <0.00%> (-100.00%) ⬇️
components/dm/spec/cluster.go 0.00% <0.00%> (-87.50%) ⬇️
components/playground/monitor.go 0.00% <0.00%> (-84.42%) ⬇️
components/playground/command.go 0.00% <0.00%> (-79.60%) ⬇️
components/dm/spec/logic.go 0.60% <0.00%> (-78.66%) ⬇️
pkg/cluster/template/scripts/dm_worker.go 0.00% <0.00%> (-71.43%) ⬇️
components/playground/main.go 4.10% <0.00%> (-68.21%) ⬇️
pkg/cluster/template/scripts/dm_master.go 0.00% <0.00%> (-67.22%) ⬇️
... and 80 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 295ade4...922ef95. Read the comment docs.

@AstroProfundis AstroProfundis added the category/document Categorizes issue or PR as a document update. label Dec 18, 2020
AstroProfundis
AstroProfundis reviewed Dec 18, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
lucklove and others added 2 commits December 18, 2020 14:35
@lucklove @AstroProfundis
Apply suggestions from code review
645cd51 
Co-authored-by: Allen Zhong <allen@moe.cat>
@lucklove
Address comment
d7a0323
9547
9547 reviewed Dec 18, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@AstroProfundis
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 18, 2020
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 18, 2020
@ti-chi-bot
Copy link
Member

Can merge label has been added.

Git tree hash: 6b33c96

9547
9547 approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@9547 9547 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@lucklove
Copy link
Member Author

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2020
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Dec 18, 2020
@lucklove
Copy link
Member Author

/hold cancel

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2020
@lucklove
Copy link
Member Author

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2020
@CLAassistant
Copy link

CLAassistant commented Dec 18, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@lucklove
Copy link
Member Author

/hold cancel

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2020
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 18, 2020
@ti-chi-bot
Copy link
Member

Can merge label has been added.

Git tree hash: 922ef95

@ti-chi-bot ti-chi-bot merged commit edb12b8 into pingcap:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AstroProfundis AstroProfundis AstroProfundis left review comments

@9547 9547 9547 approved these changes

Assignees
No one assigned
Labels
category/document Categorizes issue or PR as a document update. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lucklove @codecov-io @AstroProfundis @ti-chi-bot @CLAassistant @9547 @King-Dylan