Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tw plugin): use require.resolve to avoid going outside of fs root #696

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

juliusmarminge
Copy link
Collaborator

@juliusmarminge juliusmarminge commented Mar 9, 2024

Closes #687

Copy link

vercel bot commented Mar 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-uploadthing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2024 3:41pm

Copy link

changeset-bot bot commented Mar 9, 2024

🦋 Changeset detected

Latest commit: 65a58ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
uploadthing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@juliusmarminge juliusmarminge added the release canary Trigger a canary release to npm label Mar 9, 2024
Copy link
Contributor

github-actions bot commented Mar 9, 2024

A new canary is available for testing. You can install this latest build in your project with:

pnpm add @uploadthing/dropzone@0.2.2-canary.8c54a76
pnpm add @uploadthing/mime-types@0.2.7-canary.8c54a76
pnpm add @uploadthing/react@6.3.5-canary.8c54a76
pnpm add @uploadthing/shared@6.3.5-canary.8c54a76
pnpm add @uploadthing/solid@6.2.2-canary.8c54a76
pnpm add uploadthing@6.5.3-canary.8c54a76

@github-actions github-actions bot removed the release canary Trigger a canary release to npm label Mar 9, 2024
@juliusmarminge juliusmarminge changed the title use require.resolve to fix turbo error fix(tw plugin): use require.resolve to avoid going outside of fs root Mar 9, 2024
@juliusmarminge
Copy link
Collaborator Author

Need to resolve local dev first. this works for consumers but currently running dev in the monorepo fails... : (see https://pinglabsworkspace.slack.com/archives/C052S77L05C/p1710020749504469?thread_ts=1709973815.322309&cid=C052S77L05C)

@juliusmarminge
Copy link
Collaborator Author

juliusmarminge commented Mar 10, 2024

Local issue will be resolved with this fix in Next.js to support Bun workspaces with turbo: vercel/next.js#63112

@juliusmarminge juliusmarminge marked this pull request as ready for review March 13, 2024 15:38
@juliusmarminge
Copy link
Collaborator Author

Local issue will be resolved with this fix in Next.js to support Bun workspaces with turbo: vercel/next.js#63112

Think we're good to merge even before Next.js fixes their issue. We don't currently run examples with --turbo so we wont run into the bug unless we explicitely provide it and let's be frank, we don't even run the tailwind example too often.

Stuff works for consumers nevertheless

@juliusmarminge juliusmarminge merged commit 8773859 into main Mar 13, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: @uploadthing/react/dist leaves the filesystem root
2 participants