Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Node 20.13 compat #813

Merged
merged 9 commits into from
May 16, 2024
Merged

fix: Node 20.13 compat #813

merged 9 commits into from
May 16, 2024

Conversation

juliusmarminge
Copy link
Collaborator

Seems like something in Node 20.13 is broken with the spread operator on Headers:

image

Symbols aren't enumerable so they shouldn't show up after a spread, yet they are...

Anyways, this refactor makes it compat with this new behavior, be it intentional or unintentional from their side...

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-uploadthing ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 11:20am

Copy link

changeset-bot bot commented May 16, 2024

🦋 Changeset detected

Latest commit: 668d35b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
uploadthing Patch
@uploadthing/shared Patch
@uploadthing/nuxt Patch
@uploadthing/react Patch
@uploadthing/solid Patch
@uploadthing/svelte Patch
@uploadthing/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@juliusmarminge
Copy link
Collaborator Author

juliusmarminge commented May 16, 2024

Opened an issue on Undici: nodejs/undici#3267

@juliusmarminge juliusmarminge merged commit 7d93270 into main May 16, 2024
10 checks passed
juliusmarminge added a commit that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant