Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PATCH with nested fields #225

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

finrod2002
Copy link

This fixes an issue where PATCH requests with add operation and no path field containing nested fields (with '.') where not correctly applied.

For example the following PATCH request:

{
    "Operations": [
        {
            "op": "replace",
            "value": {
                "name.familyName": "test",
                "name.formatted": "test test2"
            }
        }
    ],
    "schemas": [
        "urn:ietf:params:scim:api:messages:2.0:PatchOp"
    ]
}

wasn't correctly applied. See issue #224 for more details.

Please be aware that Ping Identity does not accept third-party contributions at this time! Please see our contribution guidelines.

What does this implement/fix? Explain your changes.

This pull request fixes #224. I'm sure the code can be greatly improved. Anyway, I needed a quick fix to be able to go on with my project and I thought it would be nice to share it. Unfortunately, I have not the time to improve it further at this moment.

Does this close any currently open issues?

It would close #224. Please see notes above about the code.

This fixes an issue where PATCH requests with add operation
and no path field containing nested fields (with '.') where
not correctly applied.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested fields not patched correctly when path field omitted
1 participant