Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change PingOne ID Data types #794

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

patrickcping
Copy link
Collaborator

@patrickcping patrickcping commented Apr 25, 2024

Change Description

Update PingOne ID types to use custom framework types that can be centrally validated and manipulated.

No changes to user experience

Required SDK Upgrades

Testing

Deferred to nightly

@patrickcping patrickcping added service/base PingOne Platform service/protect PingOne Protect service/sso PingOne SSO service/davinci PingOne DaVinci service/mfa PingOne MFA service/verify PingOne Verify service/credentials PingOne Credentials type/housekeeping labels Apr 25, 2024
@patrickcping patrickcping added this to the v1.0.0 milestone Apr 25, 2024
@patrickcping patrickcping self-assigned this Apr 25, 2024
@patrickcping patrickcping marked this pull request as ready for review April 25, 2024 12:01
@patrickcping patrickcping requested a review from a team as a code owner April 25, 2024 12:01
@patrickcping patrickcping merged commit 9b86453 into v1.0.0-development Apr 25, 2024
10 checks passed
@patrickcping patrickcping deleted the change-pingone-id-types-202404 branch April 25, 2024 12:28
patrickcping added a commit that referenced this pull request Jun 19, 2024
* `resource/pingone_image`: Migrated to plugin framework. (#509)

* `resource/pingone_image`: Migrated to plugin framework.

* changelog

* update code standards

* upgrade doc

* add version 1 doc template

* `resource/pingone_mfa_fido_policy`: Removal of deprecated resource for `v1.0.0` (#625)

* `resource/pingone_mfa_fido_policy`: Removal of deprecated resource

* changelog

* `resource/pingone_mfa_policies`: Removal of deprecated resource (#626)

* `resource/pingone_mfa_policies`: Removal of deprecated resource

* changelog

* `resource/pingone_mfa_policy`: Removal of deprecated parameters `platform` and `security_key` (#627)

* `resource/pingone_mfa_policy`: Removal of deprecated parameters `platform` and `security_key`

* changelog

* upgrade doc

* `data-source/pingone_organization`: Removal of deprecated platform URL computed attributes (v.1.0.0) (#628)

* `data-source/pingone_organization`: Removal of deprecated platform URL computed attributes

* spelling correction in upgrade guide

* changelog

* code optimisation from lint check

* `resource/pingone_environment`: Removal of deprecated parameter `default_population` and computed attribute `default_population_id` (`v1.0.0`) (#629)

* `resource/pingone_environment`: Removal of deprecated parameter `default_population` and computed attribute `default_population_id`

* changelog

* `resource/pingone_mfa_application_push_credential`: Removal of deprecated parameter `fcm.key` (`v1.0.0`) (#630)

* `resource/pingone_mfa_application_push_credential`: Removal of deprecated parameter `fcm.key`

* changelog

* upgrade guide

* `resource/pingone_environment`: Remove `timeouts` parameter block (#643)

* `resource/pingone_environment`: Remove `timeout` parameter block

* upgrade guide doc

* changelog

* `resource/pingone_mfa_application_push_credential`: Changed the `apns`, `fcm` and `hms` data types (#644)

* `resource/pingone_mfa_application_push_credential`: Changed the `apns`, `fcm` and `hms` data types

* remove unused code

* changelog

* `resource/pingone_mfa_settings`: Removal of deprecated parameter `authentication` (#645)

* `resource/pingone_mfa_settings`: Removal of deprecated parameter `authentication`

* changelog

* `pingone_user`: Removed the deprecated `status` parameter/attribute from the resource and data source (#647)

* `pingone_user`: Removed the deprecated `status` parameter/attribute from the resource and data source

* changelog

* merge corrections

* Remove deprecated attributes application (`v1.0.0`) (#656)

* remove attribute first draft

* corrected tests

* correct ds test

* changelog

* upgrade guide update

* `resource/pingone_resource_grant`: Changed parameters `resource_id` and `scopes` to be read-only (`v1.0.0`) (#657)

* `resource/pingone_resource_grant`: Changed parameters `resource_id` and `scopes` to be read-only

* changelog

* update changelog types

* `resource/pingone_resource_attribute`: Changed parameter `resource_id` to be read-only (#658)

* `resource/pingone_resource_attribute`: Changed parameter `resource_id` to be read-only

* changelog

* Update application resource grant upgrade doc text (#659)

* `resource/pingone_schema_attribute`: Changed parameter `schema_id` to be read-only (#660)

* `resource/pingone_schema_attribute`: Changed parameter `schema_id` to be read-only

* changelog

* Change image logo data types (`v1.0.0`) (#661)

* `pingone_identity_provider` changes

* `pingone_branding_settings` changes

* `pingone_branding_theme` changes

* lint

* changelog

* update documentation

* `resource/pingone_identity_provider`: Changed block data types (#662)

* `resource/pingone_identity_provider`: Changed block data types

* upgrade guide

* changelog

* `resource/pingone_webhook`: Changed block data types (#663)

* `resource/pingone_webhook`: Changed block data types

* changelog

* Change the `data_filter` block parameter data type and rename (#664)

* Change the `data_filter` block parameter data type and rename

* fix validators

* changelog

* Change environment block parameters (#665)

* change environment block parameters

* changelog

* update upgrade guide

* lint

* update changelog

* bug fixes and test corrections

* `data-source/pingone_groups`: Changed the data_filter parameter data type and renamed to data_filters (`v1`) (#677)

`data-source/pingone_groups`: Changed the data_filter parameter data type and renamed to data_filters

* correct changelog

* `pingone_application`: Removal of deprecated attribute `saml_options.sp_verification_certificate_ids` (#681)

* `pingone_application`: Removal of deprecated attribute `saml_options.sp_verification_certificate_ids`

* changelog

* Changed `pingone_application` data source data types (#682)

* Changed `pingone_application` data source data types

* fix lint

* changelog

* `data-source/pingone_licenses`: Change the data filter type and rename (#730)

* `data-source/pingone_licenses`: Change the data filter type and rename

* changelog

* Merge branch 'main' into v1.0.0-development

* Merge main

* merge conflicts

* `resource/pingone_application`: Migrate to plugin framework and migrate data types (#683)

* `resource/pingone_application`: Migrate to plugin framework

* schema (2)

* update tests

* schema (3)

* schema (4)

* schema (5)

* development updates

* development and doc updates

* fix initial test problems

* update based on testing

* merge 768

* merge 769

* draft of schema changes

* google play data handling changes

* jsontype lib

* testing updates

* lint

* refactor to reduce duplicate code

* upgrade guide

* changelog

* Refactor OIDC Application client ID and client secret handling (#781)

* remove `oidc_options.client_id` and `oidc_options.client_secret` from `pingone_application`

* changelog

* application secret updates

* changelog

* refactor

* upgrade guide

* upgrade guide

* update upgrade guide

* `resource/pingone_application`: add support for previous secrets for rotation

* testing

* terrafmt

* Changed date-time fields to use custom RFC3339 data type (#784)

* Changed date-time fields to use custom RFC3339 data type

* changelog

* remove unnecessary validation

* Change JSON fields to use custom JSON data type (#785)

* Change JSON fields to use custom JSON data type

* changelog

* testing fixes

* `resource/pingone_custom_domain_verify`: Fix timeouts param and change data type (#786)

* `resource/pingone_custom_domain_verify`: Fix timeouts param and change data type

* changelog

* small changes

* Rename MFA policy based resources/data sources to MFA Device policy (#788)

* Rename MFA policy based resources/data sources to MFA Device policy

* update examples

* changelog

* fix tests

* upgrade guide

* Remove the provider parameter `force_delete_production_type` (#787)

* Remove the provider parameter `force_delete_production_type`

* changelog

* `resource/pingone_notification_policy`: Change the `quota` data type (#789)

* `resource/pingone_notification_policy`: Change the `quota` data type

* changelog

* Change PingOne ID Data types (#794)

* Change PingOne ID Data types

* lint

* update go.work

* update go.work.sum

* Change the `davinci_application` and `trigger` computed attribute data types (#795)

* Change the `davinci_application` and `trigger` computed attribute data types

* changelog

* `resource/pingone_notification_settings_email`: Change the `from` and `reply_to` data types (#796)

* `resource/pingone_notification_settings_email`: Change the `from` and `reply_to` data types

* changelog

* `resource/pingone_mfa_settings`: Migrate to framework and change data types (#797)

* Migrate `pingone_mfa_settings` to framework and change data types

* changelog

* upgrade guide

* `resource/pingone_gateway`: Migrate to plugin framework (#798)

* migrate `pingone_gateway` to framework draft

* development updates

* switch `user_types` to map type

* updates following testing

* changelog

* testing script cleanup

* corrections in review

* update the data source

* changelog update

* migration guide

* Migrate `pingone_password_policy` to plugin framework (#801)

* Migrate `pingone_password_policy` to plugin framework

* updates following testing

* migration guide and changelog

* `data-source/pingone_trusted_email_domain_dkim`: Migrated to plugin framework (#802)

* `data-source/pingone_trusted_email_domain_dkim`: Migrated to plugin framework

* upgrade guide and changelog

* upgrade guide addition

* `data-source/pingone_trusted_email_domain_ownership`: Migrated to plugin framework (#803)

* `data-source/pingone_trusted_email_domain_ownership`: Migrated to plugin framework

* changelog

* `pingone_mfa_device_policy`: Migrate to plugin framework (#809)

* initial development

* complete development and initial testing

* updates with testing

* full testing

* upgrade guide and changelog

* lint corrections

* Add `prompt_for_nickname_on_pairing` for each device method

* PingOne Authorize Roles and Permissions (#822)

* update utils for upcoming module

* New resource: `pingone_application_resource` (#818)

* New resource: `pingone_application_resource`

* changelog

* New resource: `pingone_authorize_application_role` (#817)

* New resource: `pingone_authorize_application_role`

* changelog

* draft `pingone_authorize_application_role_permission` resource (#821)

* draft `pingone_authorize_application_role_permission` resource

* changelog

* new `pingone_application_resource_permission` resource (#820)

* New resource: `pingone_application_resource`

* changelog

* new `pingone_application_resource_permission` resource

* changelog

* correct testing error

* Updates to the `pingone_resource` resource and data source (#819)

* updates to the `pingone_resource` data source

* updates to the `pingone_resource` resource

* changelog

* new `pingone_resource_secret` resource

* new `pingone_resource_secret` data source

* updates to resource secret

* testing fix

* upgrade guide

* updates to `pingone_authorize_application_role_permission`

* New resource: `pingone_user_application_role_assignment`

* update docs

* test fixes

* updates following testing

* docs correction

* merge correction

* New resource: `pingone_authorize_api_service` (#824)

* New resource: `pingone_authorize_api_service`

* changelog

* updates following testing

* New resource: `pingone_authorize_api_service_operation` (#825)

* New resource: `pingone_authorize_api_service`

* changelog

* updates following testing

* draft `pingone_authorize_api_service_operation` resource

* changelog

* functional updates

* updates following testing

* merge correction

* add permission test check

* lint correction

* New resource: `pingone_authorize_api_service_deployment` (#826)

* New resource: `pingone_authorize_api_service`

* changelog

* updates following testing

* updates following testing

* adjust acctest helpers

* remove `$` from import shell examples

* remove the `global_options.environment.production_type_force_delete` option and add protections for `PRODUCTION` type environments

* bump provider version in docs

* `resource/pingone_identity_provider`: Add the `pkce_method` property for OIDC Identity Providers (#829)

* `resource/pingone_identity_provider`: Add the `pkce_method` property for OIDC Identity Providers

* changelog

* New resource: `pingone_population_default_identity_provider` (#831)

* New resource: `pingone_population_default_identity_provider`

* add service

* changelog

* updates following testing

* `resource/pingone_identity_provider`: Update SAML sp signing and idp verification schema (#830)

* `resource/pingone_identity_provider`: Update SAML sp signing and idp verification schema

* updates following testing

* upgrade doc

* changelog

* Add support for the `DEVICE_CODE` grant type for OIDC applications (#834)

* Add support for the `DEVICE_CODE` grant type for OIDC applications

* changelog

* Migrate `pingone_notification_template_content` to plugin framework (#837)

* Migrate `pingone_notification_template_content` to plugin framework

* changelog

* doc updates

* Correct plan modification for typed objects (#839)

* Correct plan modification for typed objects

* correct plan modification for `pingone_phone_delivery_settings`

* Support the AU region tenants with .com.au top level domains (#828)

* Support the `AU` region tenants with `.com.au` top level domains

* update upgrade guide

* changelog

* Add `append_user_agent` provider parameter

* fix client test

* replace region string with code in environment resource

* change region to region code in acc tests

* fix client init bug

* remove unnecessary debug markers

* docs update

* updates to client existence checks

* update `region` field

* upgrade guide

* github workflows

* changelog

* bug fixes for testing

* bug fixes

* Update test skip for risk policy

* correct test failure identity provider

* correct and build out skipped tests sign on policy action

* add retry on role assignment deletion

* correct tests for population removal restrictions

* fix credentials issuance rule test

* correct docs and lint

* `resource/pingone_risk_predictor`: Add support for the `ADVERSARY_IN_THE_MIDDLE` and `EMAIL_REPUTATION` predictors (#835)

* `resource/pingone_risk_predictor`: Add support for the `ADVERSARY_IN_THE_MIDDLE` and `EMAIL_REPUTATION` predictors

* changelog

* schema corrections

* min/max TF CLI version bump

* update upgrade guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/base PingOne Platform service/credentials PingOne Credentials service/davinci PingOne DaVinci service/mfa PingOne MFA service/protect PingOne Protect service/sso PingOne SSO service/verify PingOne Verify type/housekeeping
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant