Skip to content

Commit

Permalink
memo in return value
Browse files Browse the repository at this point in the history
  • Loading branch information
awb99 committed Oct 28, 2024
1 parent 7cc27cb commit 65ee43a
Showing 1 changed file with 21 additions and 16 deletions.
37 changes: 21 additions & 16 deletions src/dali/viewer.cljs
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,18 @@

(defn viewer-impl [dali-spec]
(let [[result set-result] (react/useState nil)
[error set-error] (react/useState false)]
[error set-error] (react/useState false)
ui (r/as-element
(cond
result
(let [{:keys [viewer data error]} result]
(if data
[viewer data]
[:p "error!"]))
error
[:p "error!"]
:else
[:p "loading.."]))]
(react/useEffect
(fn []
(set-result nil)
Expand All @@ -69,26 +80,20 @@
(fn []
(println "processing cleanup ..")))
(clj->js [dali-spec]))
(r/as-element
(cond
result
(let [{:keys [viewer data error]} result]
(if data
[viewer data]
[:p "error!"]))
error
[:p "error!"]
:else
[:p "loading.."]))))

(react/useMemo
(fn []
ui
)
(clj->js ui))

))

#_(defn viewer-wrapped [dali-spec]
[:f> viewer-impl dali-spec])

(defn viewer2 [dali-spec]
(let [memoized (react/useMemo viewer-impl (clj->js [dali-spec]))]
[:> memoized dali-spec]
)
)
[:> viewer-impl dali-spec])


; reagent.core/as-element function creates a React element from a Hiccup form.
Expand Down

0 comments on commit 65ee43a

Please sign in to comment.