-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/cache #20
Open
LucasPrioste92
wants to merge
52
commits into
main
Choose a base branch
from
feature/cache
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/cache #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
LucasPrioste92
commented
Jun 14, 2024
- Cached Assets
- Cached News
- Update Unit Tests
# Conflicts: # app/src/main/java/dev/pinkroom/marketsight/ui/MainActivity.kt
- use case to get News
- assertK - mockK - JUnit - coroutine test
- unit test (NewsRemoteDataSource) - refactor code
- refactor code
- refactor code
- empty screen when news are empty - loading shimmer effect while loading main news
- refresh news - show snackbar error - refactor code
- refactor news repository and news remote source
- empty content ui
- desc/asc ui - symbols subscribed ui
- assets Remote Data Source, Repository and Use Case - setup paper API, stock service, crypto service - refactor alpaca data api
- use case subscribe/unsubscribe asset
- assets filter by stock or crypto
- empty content layout - search input logic
- get asset detail screen - get bars detail screen
- get real time bars - calculate values related to asset
- get real time trades - filter trades and quotes
- refresh logic
- unit test refactor - clean code
… showing cached data and there is an internet connection and you can get the latest news
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.