Feature/konsist #21
Open
Feature/konsist #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
LucasPrioste92
commented
Jun 14, 2024
LucasPrioste92
commented
- Add lib Konsist to ensure conventions and consistency
- Add Retry when subscribing Real Time News
- Update Unit Tests
# Conflicts: # app/src/main/java/dev/pinkroom/marketsight/ui/MainActivity.kt
- use case to get News
- assertK - mockK - JUnit - coroutine test
- unit test (NewsRemoteDataSource) - refactor code
- refactor code
- refactor code
- empty screen when news are empty - loading shimmer effect while loading main news
- refresh news - show snackbar error - refactor code
- refactor news repository and news remote source
- empty content ui
- desc/asc ui - symbols subscribed ui
- assets Remote Data Source, Repository and Use Case - setup paper API, stock service, crypto service - refactor alpaca data api
- use case subscribe/unsubscribe asset
- assets filter by stock or crypto
- empty content layout - search input logic
- get asset detail screen - get bars detail screen
- get real time bars - calculate values related to asset
- get real time trades - filter trades and quotes
- refresh logic
- unit test refactor - clean code
… showing cached data and there is an internet connection and you can get the latest news
…real time news - update unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.