Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elastic connection resurrect on split destroy #161

Merged
merged 6 commits into from
Oct 13, 2022

Conversation

jurosm
Copy link
Contributor

@jurosm jurosm commented Sep 27, 2022

This resurrects elastic connection pool in case elastic server is down or the connection is broken for some reason.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR! Can you please add a unit test?

@jurosm
Copy link
Contributor Author

jurosm commented Sep 28, 2022

Thanks for opening a PR! Can you please add a unit test?

Glad to contribute! Sure I will add a unit test for this. 👍

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KillenX

This comment was marked as off-topic.

@penumbra23
Copy link

@mcollina Merging anytime soon?

@mcollina mcollina merged commit 809980b into pinojs:master Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants