Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix support for elasticsearch v7 + add types #169

Conversation

robyte-ctrl
Copy link
Contributor

@robyte-ctrl robyte-ctrl commented Aug 17, 2023

opened the PR in here by mistake (meant to merge it in my fork's master branch) so feel free to close it

but this PR does fix #166 and it also adds types so it's easier to use this library in a typescript project

lib.d.ts Show resolved Hide resolved
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

This is a semver-major change, right?

@robyte-ctrl
Copy link
Contributor Author

Good work!

This is a semver-major change, right?

@mcollina shouldn't be, although I have renamed some of the options so that they follow the camelCase naming notation, the old names still work and I've added some tests to make sure that they do

if you want to remove the old names completely then that would be a semver-major change

@mcollina
Copy link
Member

I see you have removed --bulk-size from the CLI options, hence my guess.

@robyte-ctrl
Copy link
Contributor Author

robyte-ctrl commented Aug 17, 2023

I see you have removed --bulk-size from the CLI options, hence my guess.

@mcollina oh, right, I removed it because it wasn't doing anything

image

not sure how that could be considered deprecated since a deprecation usually means that the deprecated thing still works

have I perhaps missed something?

should I add it back and leave it as is just to keep the interface the same?

@mcollina
Copy link
Member

ah no worries! That's ok.

@robyte-ctrl robyte-ctrl changed the title fix support for elasticsearch v7 and opensearch + add types fix support for elasticsearch v7 + add types Aug 17, 2023
@robyte-ctrl robyte-ctrl force-pushed the fallback-to-version-7-of-elasticsearch-client branch from ef6e8ff to 3bf6a7b Compare August 17, 2023 16:31
@mcollina mcollina merged commit e4beebb into pinojs:master Aug 18, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking minor update due to client dependency?
2 participants