Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call .end() on thread-stream before exiting the process. #1296

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Call .end() on thread-stream before exiting the process. #1296

merged 1 commit into from
Jan 10, 2022

Conversation

mcollina
Copy link
Member

@mcollina mcollina requested a review from jsumners January 10, 2022 11:15
@mcollina mcollina mentioned this pull request Jan 10, 2022
Closed
jsumners
jsumners approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mcollina mcollina merged commit 8dceecd into master Jan 10, 2022
@mcollina mcollina deleted the fix-async-write-startup branch January 10, 2022 14:32
@mcollina mcollina mentioned this pull request Jan 19, 2022
Closed
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsumners jsumners jsumners approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nothing gets logged in uncaughtException
2 participants
@mcollina @jsumners