Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect type definition of censor function #1389

Merged
merged 2 commits into from
Apr 8, 2022

Conversation

mksmtn
Copy link
Contributor

@mksmtn mksmtn commented Mar 31, 2022

censor takes two arguments: value and path

`censor` takes two arguments: value and path
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a unit test/assertion? We use tsd.

censor function should take two arguments: value and path
@mksmtn
Copy link
Contributor Author

mksmtn commented Mar 31, 2022

never used tsd, hope these assertions are fine

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 47e97f7 into pinojs:master Apr 8, 2022
@mksmtn mksmtn deleted the patch-1 branch April 8, 2022 21:52
@github-actions
Copy link

github-actions bot commented Apr 9, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants