Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LevelWithSilent as an exported type #1399

Merged

Conversation

deongroenewald
Copy link
Contributor

As per #1352, the community supported @types/pino-multi-stream package has a dependency on LevelWithSilent.

However, that PR is lacking any tests.

I've added a simple types test but open to feedback if there are bettter/different ways to test this.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 53c914c into pinojs:master Apr 8, 2022
@deongroenewald deongroenewald deleted the add-level-with-silent-type-export branch November 1, 2022 14:34
Copy link

github-actions bot commented Nov 2, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants