-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump serializer library, for https://github.com/pinojs/pino-std… #1410
Conversation
This would incur a major bump for Pino. We will do that at some point, but I'm not sure we are ready for it yet. You can use the newer version of |
I would have hoped this would get part of Fastify v4 as a bump in Pino major would have to wait for a Fastify major to be included there and that will I guess take a while before that happens |
CI is failing, could you update it? @voxpelli I cannot delay Fastify v4 further to do another pino major bump :(. We'll likely do a Fastify v5 / pino v8 combo once we are ready. |
@mcollina I totally understand, I should have caught this earlier if I wanted to push it :) On a sidenote: Why didn't Dependabot suggest this update? |
@mcollina How much work would bump entail? I can contribute some effort if that helps |
Check out https://github.com/pinojs/pino/milestone/4. The most important change that need to be finished is #1249 |
@voxpelli Meanwhile, will you be able to fix this PR? |
@kibertoad I can try, but since it’s not mine and I’m not a maintainer I can only open a new one that replaces this one |
@voxpelli that also works |
@voxpelli fastify v4 lands next Tuesday, so we need pino 8 this week. is it feasible to create a new PR by EOD tomorrow? |
Superseded by #1449 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
see pinojs/pino-std-serializers#88