Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(API): add description to level constructor option #1488

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

KoltesDigital
Copy link
Contributor

@KoltesDigital KoltesDigital commented Jul 7, 2022

This option is described in logger.levels but not in its own section.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

docs/api.md Outdated
@@ -57,6 +57,8 @@ The name of the logger. When set adds a `name` field to every JSON line logged.

Default: `'info'`

The minimum level to log, i.e. lower levels won't be outputted. This reduces the load, as typically, debug and trace messages are only useful for development, quite verbose, and not needed in production.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The minimum level to log, i.e. lower levels won't be outputted. This reduces the load, as typically, debug and trace messages are only useful for development, quite verbose, and not needed in production.
The minimum level to log: Pino will not log messages with a lower level. Setting this option reduces the load, as typically, debug and trace logs are only valid for development, and not needed in production.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to your suggestion.

@github-actions
Copy link

github-actions bot commented Jul 9, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants