Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: dedup works with multistream (refs: #1506) #1508

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

bl00dhound
Copy link
Contributor

@bl00dhound bl00dhound commented Aug 3, 2022

If dedupe option is set to true we need to iterate by streams array from last items to first.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit d15be16 into pinojs:master Aug 4, 2022
@github-actions
Copy link

github-actions bot commented Aug 5, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants