feat(types): forbid using default log fn when custom only used (#1998) #1999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
reviewed
Jul 2, 2024
test/types/pino.ts
Outdated
| // @ts-expect-error | ||
| loggerCustomLevel.debug('test'); | ||
| // @ts-expect-error | ||
| loggerCustomLevel.trace('test'); |
There was a problem hiding this comment.
Thanks, @mcollina. I've moved the type tests to tsd files and used expectError as recommended!
alexandresoro
pushed a commit
to alexandresoro/ouca
that referenced
this pull request
Sep 4, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [pino](https://getpino.io) ([source](https://github.com/pinojs/pino)) | dependencies | minor | [`9.3.2` -> `9.4.0`](https://renovatebot.com/diffs/npm/pino/9.3.2/9.4.0) | --- ### Release Notes <details> <summary>pinojs/pino (pino)</summary> ### [`v9.4.0`](https://github.com/pinojs/pino/releases/tag/v9.4.0) [Compare Source](pinojs/pino@v9.3.2...v9.4.0) #### What's Changed - Drop failing pnpm tests by [@​mcollina](https://github.com/mcollina) in pinojs/pino#2015 - Add bun plugin link to docs by [@​vktrl](https://github.com/vktrl) in pinojs/pino#2016 - build(deps-dev): bump [@​types/node](https://github.com/types/node) from 20.14.13 to 22.0.0 by [@​dependabot](https://github.com/dependabot) in pinojs/pino#2017 - docs: Update transports.md by [@​Imgodmaoyouknow](https://github.com/Imgodmaoyouknow) in pinojs/pino#2027 - build(deps-dev): bump [@​yao-pkg/pkg](https://github.com/yao-pkg/pkg) from 5.12.0 to 5.12.1 by [@​dependabot](https://github.com/dependabot) in pinojs/pino#2031 - feat(types): forbid using default log fn when custom only used ([#​1998](pinojs/pino#1998)) by [@​chernodub](https://github.com/chernodub) in pinojs/pino#1999 - feat: accept level in capitals by [@​balaji-atoa](https://github.com/balaji-atoa) in pinojs/pino#2034 #### New Contributors - [@​vktrl](https://github.com/vktrl) made their first contribution in pinojs/pino#2016 - [@​Imgodmaoyouknow](https://github.com/Imgodmaoyouknow) made their first contribution in pinojs/pino#2027 - [@​chernodub](https://github.com/chernodub) made their first contribution in pinojs/pino#1999 - [@​balaji-atoa](https://github.com/balaji-atoa) made their first contribution in pinojs/pino#2034 **Full Changelog**: pinojs/pino@v9.3.2...v9.4.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC42NC4xIiwidXBkYXRlZEluVmVyIjoiMzguNjQuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19--> Reviewed-on: https://git.tristess.app/alexandresoro/ouca/pulls/79 Reviewed-by: Alexandre Soro <code@soro.dev> Co-authored-by: renovate <renovate@git.tristess.app> Co-committed-by: renovate <renovate@git.tristess.app>
1 task
renovate bot
referenced
this pull request
in redwoodjs/redwood
Sep 9, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino](https://getpino.io) ([source](https://github.com/pinojs/pino)) | [`9.3.2` -> `9.4.0`](https://renovatebot.com/diffs/npm/pino/9.3.2/9.4.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>pinojs/pino (pino)</summary> ### [`v9.4.0`](https://github.com/pinojs/pino/releases/tag/v9.4.0) [Compare Source](https://github.com/pinojs/pino/compare/v9.3.2...v9.4.0) #### What's Changed - Drop failing pnpm tests by [@​mcollina](https://github.com/mcollina) in [https://github.com/pinojs/pino/pull/2015](https://github.com/pinojs/pino/pull/2015) - Add bun plugin link to docs by [@​vktrl](https://github.com/vktrl) in [https://github.com/pinojs/pino/pull/2016](https://github.com/pinojs/pino/pull/2016) - build(deps-dev): bump [@​types/node](https://github.com/types/node) from 20.14.13 to 22.0.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/pinojs/pino/pull/2017](https://github.com/pinojs/pino/pull/2017) - docs: Update transports.md by [@​Imgodmaoyouknow](https://github.com/Imgodmaoyouknow) in [https://github.com/pinojs/pino/pull/2027](https://github.com/pinojs/pino/pull/2027) - build(deps-dev): bump [@​yao-pkg/pkg](https://github.com/yao-pkg/pkg) from 5.12.0 to 5.12.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/pinojs/pino/pull/2031](https://github.com/pinojs/pino/pull/2031) - feat(types): forbid using default log fn when custom only used ([#​1998](https://github.com/pinojs/pino/issues/1998)) by [@​chernodub](https://github.com/chernodub) in [https://github.com/pinojs/pino/pull/1999](https://github.com/pinojs/pino/pull/1999) - feat: accept level in capitals by [@​balaji-atoa](https://github.com/balaji-atoa) in [https://github.com/pinojs/pino/pull/2034](https://github.com/pinojs/pino/pull/2034) #### New Contributors - [@​vktrl](https://github.com/vktrl) made their first contribution in [https://github.com/pinojs/pino/pull/2016](https://github.com/pinojs/pino/pull/2016) - [@​Imgodmaoyouknow](https://github.com/Imgodmaoyouknow) made their first contribution in [https://github.com/pinojs/pino/pull/2027](https://github.com/pinojs/pino/pull/2027) - [@​chernodub](https://github.com/chernodub) made their first contribution in [https://github.com/pinojs/pino/pull/1999](https://github.com/pinojs/pino/pull/1999) - [@​balaji-atoa](https://github.com/balaji-atoa) made their first contribution in [https://github.com/pinojs/pino/pull/2034](https://github.com/pinojs/pino/pull/2034) **Full Changelog**: pinojs/pino@v9.3.2...v9.4.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Josh-Walker-GM
referenced
this pull request
in redwoodjs/redwood
Sep 10, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino](https://getpino.io) ([source](https://github.com/pinojs/pino)) | [`9.3.2` -> `9.4.0`](https://renovatebot.com/diffs/npm/pino/9.3.2/9.4.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>pinojs/pino (pino)</summary> ### [`v9.4.0`](https://github.com/pinojs/pino/releases/tag/v9.4.0) [Compare Source](https://github.com/pinojs/pino/compare/v9.3.2...v9.4.0) #### What's Changed - Drop failing pnpm tests by [@​mcollina](https://github.com/mcollina) in [https://github.com/pinojs/pino/pull/2015](https://github.com/pinojs/pino/pull/2015) - Add bun plugin link to docs by [@​vktrl](https://github.com/vktrl) in [https://github.com/pinojs/pino/pull/2016](https://github.com/pinojs/pino/pull/2016) - build(deps-dev): bump [@​types/node](https://github.com/types/node) from 20.14.13 to 22.0.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/pinojs/pino/pull/2017](https://github.com/pinojs/pino/pull/2017) - docs: Update transports.md by [@​Imgodmaoyouknow](https://github.com/Imgodmaoyouknow) in [https://github.com/pinojs/pino/pull/2027](https://github.com/pinojs/pino/pull/2027) - build(deps-dev): bump [@​yao-pkg/pkg](https://github.com/yao-pkg/pkg) from 5.12.0 to 5.12.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/pinojs/pino/pull/2031](https://github.com/pinojs/pino/pull/2031) - feat(types): forbid using default log fn when custom only used ([#​1998](https://github.com/pinojs/pino/issues/1998)) by [@​chernodub](https://github.com/chernodub) in [https://github.com/pinojs/pino/pull/1999](https://github.com/pinojs/pino/pull/1999) - feat: accept level in capitals by [@​balaji-atoa](https://github.com/balaji-atoa) in [https://github.com/pinojs/pino/pull/2034](https://github.com/pinojs/pino/pull/2034) #### New Contributors - [@​vktrl](https://github.com/vktrl) made their first contribution in [https://github.com/pinojs/pino/pull/2016](https://github.com/pinojs/pino/pull/2016) - [@​Imgodmaoyouknow](https://github.com/Imgodmaoyouknow) made their first contribution in [https://github.com/pinojs/pino/pull/2027](https://github.com/pinojs/pino/pull/2027) - [@​chernodub](https://github.com/chernodub) made their first contribution in [https://github.com/pinojs/pino/pull/1999](https://github.com/pinojs/pino/pull/1999) - [@​balaji-atoa](https://github.com/balaji-atoa) made their first contribution in [https://github.com/pinojs/pino/pull/2034](https://github.com/pinojs/pino/pull/2034) **Full Changelog**: pinojs/pino@v9.3.2...v9.4.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
github-merge-queue bot
referenced
this pull request
in rustymotors/server
Sep 16, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino](https://getpino.io) ([source](https://github.com/pinojs/pino)) | [`^9.3.2` -> `^9.4.0`](https://renovatebot.com/diffs/npm/pino/9.3.2/9.4.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [pino](https://getpino.io) ([source](https://github.com/pinojs/pino)) | [`^9.3.2` -> `^9.4.0`](https://renovatebot.com/diffs/npm/pino/8.17.1/9.4.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>pinojs/pino (pino)</summary> ### [`v9.4.0`](https://github.com/pinojs/pino/releases/tag/v9.4.0) [Compare Source](https://github.com/pinojs/pino/compare/v9.3.2...v9.4.0) #### What's Changed - Drop failing pnpm tests by [@​mcollina](https://github.com/mcollina) in [https://github.com/pinojs/pino/pull/2015](https://github.com/pinojs/pino/pull/2015) - Add bun plugin link to docs by [@​vktrl](https://github.com/vktrl) in [https://github.com/pinojs/pino/pull/2016](https://github.com/pinojs/pino/pull/2016) - build(deps-dev): bump [@​types/node](https://github.com/types/node) from 20.14.13 to 22.0.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/pinojs/pino/pull/2017](https://github.com/pinojs/pino/pull/2017) - docs: Update transports.md by [@​Imgodmaoyouknow](https://github.com/Imgodmaoyouknow) in [https://github.com/pinojs/pino/pull/2027](https://github.com/pinojs/pino/pull/2027) - build(deps-dev): bump [@​yao-pkg/pkg](https://github.com/yao-pkg/pkg) from 5.12.0 to 5.12.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/pinojs/pino/pull/2031](https://github.com/pinojs/pino/pull/2031) - feat(types): forbid using default log fn when custom only used ([#​1998](https://github.com/pinojs/pino/issues/1998)) by [@​chernodub](https://github.com/chernodub) in [https://github.com/pinojs/pino/pull/1999](https://github.com/pinojs/pino/pull/1999) - feat: accept level in capitals by [@​balaji-atoa](https://github.com/balaji-atoa) in [https://github.com/pinojs/pino/pull/2034](https://github.com/pinojs/pino/pull/2034) #### New Contributors - [@​vktrl](https://github.com/vktrl) made their first contribution in [https://github.com/pinojs/pino/pull/2016](https://github.com/pinojs/pino/pull/2016) - [@​Imgodmaoyouknow](https://github.com/Imgodmaoyouknow) made their first contribution in [https://github.com/pinojs/pino/pull/2027](https://github.com/pinojs/pino/pull/2027) - [@​chernodub](https://github.com/chernodub) made their first contribution in [https://github.com/pinojs/pino/pull/1999](https://github.com/pinojs/pino/pull/1999) - [@​balaji-atoa](https://github.com/balaji-atoa) made their first contribution in [https://github.com/pinojs/pino/pull/2034](https://github.com/pinojs/pino/pull/2034) **Full Changelog**: pinojs/pino@v9.3.2...v9.4.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/rustymotors/server). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6ImRldiIsImxhYmVscyI6W119-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forbids using default log methods when
useOnlyCustomLevelsused.Only improves types, the actual behavior were not changed.
Closes #1998