feature: allow sync flag to be passed to ThreadStream for synchronous… #2063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mcollina Do you think this works ? |
mcollina
requested changes
Oct 14, 2024
|
@mcollina Added unit test. |
mcollina
reviewed
Oct 15, 2024
|
You might need to pass fsync the file descriptor, so you might not be able to read it.
|
tests: fix unit test
|
@mcollina Ah yess, updated PR. |
Ubuntu 22 failing for some reason. :( Need to re-check this. Had worked on my fork |
tests: fix unit test
|
@mcollina @kibertoad Good to merge now :) |
alexandresoro
pushed a commit
to alexandresoro/ouca
that referenced
this pull request
Oct 16, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [pino](https://getpino.io) ([source](https://github.com/pinojs/pino)) | dependencies | minor | [`9.4.0` -> `9.5.0`](https://renovatebot.com/diffs/npm/pino/9.4.0/9.5.0) | --- ### Release Notes <details> <summary>pinojs/pino (pino)</summary> ### [`v9.5.0`](https://github.com/pinojs/pino/releases/tag/v9.5.0) [Compare Source](pinojs/pino@v9.4.0...v9.5.0) #### What's Changed - build(deps-dev): bump [@​yao-pkg/pkg](https://github.com/yao-pkg/pkg) from 5.12.1 to 5.13.0 by [@​dependabot](https://github.com/dependabot) in pinojs/pino#2042 - build(deps): bump pino-abstract-transport from 1.2.0 to 2.0.0 by [@​dependabot](https://github.com/dependabot) in pinojs/pino#2043 - Update transports.md by [@​Jhon-Mosk](https://github.com/Jhon-Mosk) in pinojs/pino#2041 - doc: Add Transport [@​macfja/pino-fingers-crossed](https://github.com/macfja/pino-fingers-crossed) by [@​MacFJA](https://github.com/MacFJA) in pinojs/pino#2047 - build(deps-dev): bump [@​yao-pkg/pkg](https://github.com/yao-pkg/pkg) from 5.13.0 to 5.15.0 by [@​dependabot](https://github.com/dependabot) in pinojs/pino#2050 - docs->added pino-hana transport by [@​HiImGiovi](https://github.com/HiImGiovi) in pinojs/pino#2059 - docs -> [#​2061](pinojs/pino#2061) Alphabetize transport list and reorder sections in documentation by [@​superherobtf1985](https://github.com/superherobtf1985) in pinojs/pino#2062 - feature: allow sync flag to be passed to ThreadStream for synchronous… by [@​karankraina](https://github.com/karankraina) in pinojs/pino#2063 - fix: Ensure silent log level is respected with browser.transmit option by [@​SrsDanny](https://github.com/SrsDanny) in pinojs/pino#2052 #### New Contributors - [@​MacFJA](https://github.com/MacFJA) made their first contribution in pinojs/pino#2047 - [@​HiImGiovi](https://github.com/HiImGiovi) made their first contribution in pinojs/pino#2059 - [@​superherobtf1985](https://github.com/superherobtf1985) made their first contribution in pinojs/pino#2062 - [@​karankraina](https://github.com/karankraina) made their first contribution in pinojs/pino#2063 - [@​SrsDanny](https://github.com/SrsDanny) made their first contribution in pinojs/pino#2052 **Full Changelog**: pinojs/pino@v9.4.0...v9.5.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMjQuMCIsInVwZGF0ZWRJblZlciI6IjM4LjEyNC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Reviewed-on: https://git.tristess.app/alexandresoro/ouca/pulls/226 Reviewed-by: Alexandre Soro <code@soro.dev> Co-authored-by: renovate <renovate@git.tristess.app> Co-committed-by: renovate <renovate@git.tristess.app>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
syncflag to be passed to ThreadStream for sync logging.Ref - #1801