Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): add links to gcp logging formatter #2088

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nielm
Copy link

@nielm nielm commented Nov 18, 2024

Update documentation to include links to @google-cloud/pino-logging-gcp-config

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

Screenshot 2024-11-18 at 17 45 11

^ This URL is wrong. Could you fix it?

@nielm
Copy link
Author

nielm commented Nov 18, 2024

Screenshot 2024-11-18 at 17 45 11

^ This URL is wrong. Could you fix it?

yes I know - I am trying to publish v1.0.2 to fix it (and also fix a CVE in jasmine deps), but the tool that @google-cloud uses to publish to npmjs is also broken by this incorrect URL!

@nielm
Copy link
Author

nielm commented Nov 20, 2024

Screenshot 2024-11-18 at 17 45 11 ^ This URL is wrong. Could you fix it?

yes I know - I am trying to publish v1.0.2 to fix it (and also fix a CVE in jasmine deps), but the tool that @google-cloud uses to publish to npmjs is also broken by this incorrect URL!

This is now fixed.

https://www.npmjs.com/package/@google-cloud/pino-logging-gcp-config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants