-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not cast to string Error#stack. #464
Conversation
yes I agree - but this is now a breaking change, so should be in v5 but not v4 |
We also need to discuss one case: If I However if I assign: So, should we set stack to an empty string when the |
I don't think so. We landed a botched commit that we shouldn't. Let's restore proper behavior.
No, you do not want to see it. Mainly because: pino.info({ hello: undefined }) Will not show the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I agree with Matteo, this is not a major but is really a fix to restore behavior. Does this pass the awesome test suite David built? |
I do not know how to run that, and there are no instructions. However it does fix the pino-pretty test, so I think we are good to go. |
To run just go to travis and restart build for master - prior to release. We don't have a way to run for pr's atm |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixes pinojs/pino-pretty#16.
@jsumners @davidmarkclements what do you think?