Remove log version

[thomasthiebaud]

Fixes #620

Removing v1 breaks a test in pretty.test.js. To fix it I have to update pino-pretty. I wanted to do so, but it seems there is a circular dependency when running tests pino -> pino-pretty -> pino.
How do you usually handle update both packages at the same time?

How should pino-pretty handle it? Removing this check

function isPinoLog (log) {
  return log && (log.hasOwnProperty('v') && log.v === 1)
}

seems to be the easiest way, but then pino-pretty will print logs not coming from pino like that

USERLVL:           
    hello: "world"

[thomasthiebaud]

I'm not sure about that line

[jsumners]

I think I’ll just have to find time to cut a new major of pino-pretty sooner than I planned.

[jsumners]

Work started in pinojs/pino-pretty#58

[jsumners]

@thomasthiebaud try your branch with pino-pretty@next.

[thomasthiebaud]

@jsumners Works like a charm

[jsumners]

Cool. It’ll probably be next weekend before I can get back to it.

[davidmarkclements]

to finish this off we'll need to

1. get the coverage back to 100
2. resolve conflicts

[thomasthiebaud]

Conflicts resolved. Coverage seems to be back to normal too

[davidmarkclements]

ok this is part of major, it looks like it might be time to start a v6 branch

[thomasthiebaud]

Let me know when you have one, I'll change the PR accordingly

[jsumners]

pino-pretty@3 is released. You should be able to update the dependency in this PR @thomasthiebaud

[thomasthiebaud]

@jsumners Done

[kibertoad]

What is remaining before this PR can be merged?

[mcollina]

We'll land this when we decide to cut v6 later this year.

[jsumners]

next branch has been created and this merged into it.

[jonatasbaldin]

hey there!

do you know when this change will be released?

thanks!

[mcollina]

Later this year Il giorno lun 12 ago 2019 alle 11:33 Jonatas Baldin < notifications@github.com> ha scritto:

…

hey there! do you know when this change will be released? thanks! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#623?email_source=notifications&email_token=AAAMXYYBVWH2CHF4OHTHVYLQEEU7BA5CNFSM4HCPAZ22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4CAKOI#issuecomment-520357177>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAMXY7K6HCZY45NFV5OFV3QEEU7BANCNFSM4HCPAZ2Q> .

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.