Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#11758] Separate banner into module #11759

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Nov 21, 2024

No description provided.

@emeroad emeroad linked an issue Nov 21, 2024 that may be closed by this pull request
@emeroad emeroad added this to the 3.1.0 milestone Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 59.64912% with 23 lines in your changes missing coverage. Please review.

Project coverage is 36.94%. Comparing base (692bbf5) to head (f4c92e5).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../com/navercorp/pinpoint/profiler/DefaultAgent.java 0.00% 7 Missing ⚠️
...int/common/server/banner/PinpointSpringBanner.java 0.00% 7 Missing ⚠️
.../com/navercorp/pinpoint/banner/PinpointBanner.java 80.00% 3 Missing and 2 partials ⚠️
...ava/com/navercorp/pinpoint/banner/BannerUtils.java 76.92% 3 Missing ⚠️
...vercorp/pinpoint/banner/BannerVersionTemplate.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #11759      +/-   ##
============================================
+ Coverage     36.90%   36.94%   +0.03%     
- Complexity    12401    12412      +11     
============================================
  Files          4103     4105       +2     
  Lines        100680   100664      -16     
  Branches      10538    10531       -7     
============================================
+ Hits          37157    37191      +34     
+ Misses        60531    60481      -50     
  Partials       2992     2992              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@emeroad emeroad merged commit cbcb173 into pinpoint-apm:master Nov 21, 2024
3 checks passed
@emeroad emeroad deleted the #11758_banner branch November 21, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate banner into module
1 participant