Various imrpovements - replace mode, specifing exact config location … #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and more List of changes introduces: - config structure is changed a bit to support the use case of specifing exact path of file and replace mode markers. This can be considered a breaking change and that's why I bumped the version as well (semantic versioning). - updated the README with the introduced changes from user perspective - implemented replace mode where only part of a file is replaced instead of rewriting the entire file - removed code for append mode - in my opinion this is a useless mode since the operation is not idempotent. The same result should be achievable with replace mode. - refactored some of the code with improved error handling - added testdata/output* files in .gitignore - these files are used only temporary during test execution and don't need to be tracked
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
==========================================
+ Coverage 12.46% 18.05% +5.58%
==========================================
Files 5 5
Lines 353 421 +68
==========================================
+ Hits 44 76 +32
- Misses 302 324 +22
- Partials 7 21 +14
Continue to review full report at Codecov.
|
|
Thanks for the PR and sorry for the delay merging! I'm a bit busy at the moment, but PRs are very welcome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and more
List of changes introduces:
specifing exact path of file and replace mode markers. This
can be considered a breaking change and that's why I bumped
the version as well (semantic versioning).
instead of rewriting the entire file
~for user's home directorymode since the operation is not idempotent. The same result should
be achievable with replace mode.
only temporary during test execution and don't need to be tracked