Fixes coalesce operation race condition #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettmoon
approved these changes
Sep 6, 2019
|
Do you mind rebasing against master for the new GitHub CI? |
* Add basic github ci configuration * Only build master / release branches on push
|
@garrettmoon Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though
_identifierToOperationsis a weak-weak map, we still need to remove it when we removed operation. Otherwise, it may exists race condition which leads new addedcompletionnot be called for example.A case:
Let's assume L384 and L213 runs concurrently, L384 executes firstly, then L213 executes, new added
completionwould not be called anymore.https://github.com/zhongwuzw/PINOperation/blob/eed328e43f706fa9e4b2cc38e7ed1ba83dbb1c8c/Source/PINOperationQueue.m#L384
https://github.com/zhongwuzw/PINOperation/blob/eed328e43f706fa9e4b2cc38e7ed1ba83dbb1c8c/Source/PINOperationQueue.m#L213