-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split type arguments break 0.43.0 #1267
Comments
When I run
Note that the output from rule With
and code is formatted like:
Can you try to reproduce above on your system with a file only containing your code sample and nothing else in it? I have the idea that something else in the file initiate the error you reported. |
@paul-dingemans we have a lot of rules touching the same code... I'm wondering if it's time to disable one or more of them so they stop conflicting with each other. |
Yes, I really would prefer to do so. But in order to do so, we need this #1230 to be merged... |
With the whole file, this is what it prints.
Where the line 48 is the line with the start of the generic type and line 50 is the line with the function return type. The error goes away if I put the type arguments on the same line. With just that snippet alone, it has no errors. |
Yes this is a known problem. The parameter list wrapping rule and the indent rule do not agree on the indent level. The indent rule however wins as it runs later. Those warnings of the parameter list wrapping rules can (should) be ignored |
Only the indentation rule should emit warnings about incorrect indentation to avoid conflicting warnings from different rules about the indentation of the exact same line. However, those other rules should still fix the indentation as good as they can for the case that the indent rule is not run at all. Closes pinterest#1267, pinterest#1119, pinterest#1045
Expected Behavior
I expect it to format it or accept it
Observed Behavior
It fails with an error like this
Steps to Reproduce
this snippet fails for us
Your Environment
The text was updated successfully, but these errors were encountered: