Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.48.0 does not allow nordic chars åäöåæø in package-names #1757

Closed
olekvernberg opened this issue Jan 2, 2023 · 4 comments · Fixed by #1780
Closed

0.48.0 does not allow nordic chars åäöåæø in package-names #1757

olekvernberg opened this issue Jan 2, 2023 · 4 comments · Fixed by #1780
Milestone

Comments

@olekvernberg
Copy link

When upgrading from 0.47.1 to 0.48.0, ktlint complains on package names containing åæø.

Expected Behavior

Expecting æøå to be accepted

Observed Behavior

Package name contains a disallowed character (cannot be auto-corrected) (package-name)

Steps to Reproduce

Create class Bar in package with name føø and run mvn antrun:run@ktlint

Your Environment

  • Version of ktlint used: 0.48.0
  • Relevant parts of the .editorconfig settings
  • Name and version (or code for custom task) of integration used (Gradle plugin, Maven plugin, command line, custom Gradle task): Apache Maven 3.8.1
  • Operating System and version: macOS Ventura 13.1
@blommish
Copy link

blommish commented Jan 2, 2023

Similar to #1530

@paul-dingemans
Copy link
Collaborator

More problems like this are likely to occur in this release. 0.48.0 contains some rules which formerly where experimental but now have been added to the standard rules. Also new experimental naming rules have been added in 0.48.x. Can you please run ktlint with --experimental once to identify which of the newly added experimental rules also break on nordic characters?

@olekvernberg
Copy link
Author

It seems like it also fails on property-, class- and function-names containing nordic characters when running with experimental rules:

Property name should start with a lowercase letter and use camel case (cannot be auto-corrected) (experimental:property-naming)" on properties containing nordic characters.
Class or object name should start with an uppercase letter and use camel case (cannot be auto-corrected) (experimental:class-naming)
Function name should start with a lowercase letter (except factory methods) and use camel case (cannot be auto-corrected) (experimental:function-naming)

@paul-dingemans
Copy link
Collaborator

Indeed, that is not entirely unexpected. Thnx for confirming though. Sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants