Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

annotation rule does not detect violations when array-syntax annotations are on the same line as other annotations #1765

Closed
shashachu opened this issue Jan 4, 2023 · 0 comments · Fixed by #1766
Closed

annotation rule does not detect violations when array-syntax annotations are on the same line as other annotations #1765

shashachu opened this issue Jan 4, 2023 · 0 comments · Fixed by #1766
Labels
annotation rule bug
Milestone
0.48.2

Comments

@shashachu
Copy link
Contributor

shashachu commented Jan 4, 2023 •
edited

Steps to Reproduce

@[JvmStatic Provides] @Foo
fun foo() = 42

is correctly reformatted to

@[JvmStatic Provides]
@Foo
fun foo() = 42

in IJ, but the annotation rule doesn't detect any violations.

Your Environment

  • Version of ktlint used: 0.48.1
@shashachu shashachu mentioned this issue Jan 4, 2023
Closed
5 tasks
shashachu added a commit to shashachu/ktlint that referenced this issue Jan 4, 2023
@shashachu
Fixing issue pinterest#1765
e554e79 
It seemed simplest to always force `@[...]` annotations onto separate lines.
shashachu added a commit to shashachu/ktlint that referenced this issue Jan 4, 2023
@shashachu
Fixing issue pinterest#1765
08510bf 
It seemed simplest to always force `@[...]` annotations onto separate lines.
shashachu added a commit to shashachu/ktlint that referenced this issue Jan 4, 2023
@shashachu
Fixing issue pinterest#1765
d95bebd 
It seemed simplest to always force `@[...]` annotations onto separate lines.
shashachu added a commit to shashachu/ktlint that referenced this issue Jan 4, 2023
@shashachu
Fixing issue pinterest#1765
aeb6978 
It seemed simplest to always force `@[...]` annotations onto separate lines.
shashachu added a commit to shashachu/ktlint that referenced this issue Jan 5, 2023
@shashachu
Fixing issue pinterest#1765
9b8a2cf 
It seemed simplest to always force `@[...]` annotations onto separate lines.
@paul-dingemans paul-dingemans added this to the 0.49.0 milestone Jan 5, 2023
@paul-dingemans paul-dingemans mentioned this issue Jan 15, 2023
Merged
5 tasks
@paul-dingemans paul-dingemans modified the milestones: 0.49.0, 0.48.2 Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
annotation rule bug
Projects
None yet
Milestone
0.48.2
Development

Successfully merging a pull request may close this issue.

Fixing issue #1765 with array syntax annotations shashachu/ktlint
2 participants
@shashachu @paul-dingemans