Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default patterns in case only exclude pattern are given #1847

Closed
paul-dingemans opened this issue Mar 9, 2023 · 0 comments · Fixed by #1864
Closed

Add default patterns in case only exclude pattern are given #1847

paul-dingemans opened this issue Mar 9, 2023 · 0 comments · Fixed by #1864
Labels
bug cli ktlint command line interface
Milestone
0.49.0

Comments

@paul-dingemans
Copy link
Collaborator

Only excluding didn't work, we also need to include smth.

Yes that is correct. The default (include) patters will only be applied whenever no patterns are specified. But that does not make sense when only an exclude pattern is given.

Originally posted by @paul-dingemans in #1834 (comment)
@paul-dingemans paul-dingemans added bug cli ktlint command line interface labels Mar 9, 2023
@paul-dingemans paul-dingemans added this to the 0.49.0 milestone Mar 14, 2023
paul-dingemans added a commit that referenced this issue Mar 16, 2023
@paul-dingemans
Add the default include patterns when only negate patterns are specif…
0633fd9 
…ied in Ktlint CLI

Closes #1847
@paul-dingemans paul-dingemans mentioned this issue Mar 16, 2023
Merged
6 tasks
paul-dingemans added a commit that referenced this issue Mar 17, 2023
@paul-dingemans
Add default include patterns when only negate patterns are given (#1864)
faa5e42 
* Add the default include patterns when only negate patterns are specified in Ktlint CLI

Closes #1847
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug cli ktlint command line interface
Projects
None yet
Milestone
0.49.0
Development

Successfully merging a pull request may close this issue.

Add default include patterns when only negate patterns are given pinterest/ktlint
1 participant
@paul-dingemans