-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract new no-single-line-block-comment rule from comment-wrapping rule #1980
Comments
I can not reproduce this behavior in Intellij. Typing |
Hi, @paul-dingemans thanks for adding your comments. I have attached the suggestion prompted by the Android studio. Also, this suggestion only comes for the Kotlin file. |
Ok, cool. Tnx for clarifying that. But still, I do not think it is necessary to keep the block comment if it can be replaced with a EOL comment. |
@paul-dingemans could this specific functionality maybe be pulled into a different rule, so that it can be toggled individually? |
What compelling reason do you have for that? Is Android Studio not working properly anymore after replacing |
I'm not sure that "does the rule break the IDE?" is the right litmus test for this. The rule does two things. There's nothing inherent in "external content wrapping" which says that block comments should be converted to EOL comments. It simply makes sense to decouple them. |
True, that is a valid argument. |
CommentWrapping
should ignore /* no-op */
type of comments
Hi, @paul-dingemans is this issue up for grabs? (Although I am new to this repo so I might require some guidance as well 😅) |
Yes sure, please give it a try. But, I want to try to release the |
Hi @paul-dingemans, sure I will pick #1938 |
Hi @paul-dingemans in regards to original issues, I still think
so we must use
in this case. Although in this case, comment wrapping doesn't report anything. But this can create inconsistency throughout the code |
This is already catered for.
|
Expected Behavior
Comments like
/* no-op */
should not be reported by the ruleCommentWrapping
as in Kotlin these are auto suggested by IDE when typingnoop
Observed Behavior
Ktlint
reports the/* no-op */
as this is single line comment, ktlint suggests to use// no-op
Your Environment
Ktlint
bydetekt
at version 0.49.0The text was updated successfully, but these errors were encountered: