Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up logging dependencies #1998

Closed
paul-dingemans opened this issue May 7, 2023 · 0 comments · Fixed by #1999
Closed

Clean up logging dependencies #1998

paul-dingemans opened this issue May 7, 2023 · 0 comments · Fixed by #1999

Comments

@paul-dingemans
Copy link
Collaborator

I am not sure, but I have found two occurrences of logging dependencies that are unwanted and may or may not be related to your problem.

  1. ktlint-ruleset-standard has an unneeded implementation dependency on io.github.microutils:kotlin-logging-jvm:3.0.5 and ktlint-rule-engine has a testImplementation dependency on ktlint-ruleset-standard.
  2. ktlint-test has an api dependency on logback which is only needed for a unit test. The ktlint-rule-engine has a test implementation dependency on ktlint-test.

I will create a PR to resolve above and merge it to master. I will let you know when it is ready. Will you be able to validate against the snapshot build whether this solves your problem?

Originally posted by @paul-dingemans in #1875 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant