Check extra whitespace success, but check extra tab character in the begin of line does not work

[ElenaSpb]

gradle task ktlint failed if there are extra whitespaces with
error line="9" column="1" severity="error" message="Unexpected indentation (11) (it should be 8) (cannot be auto-corrected)" source="indent"
for example.

but if there are extra tab character in the begining of line - the task finish success, which is not expected.

[shashachu]

@ElenaSpb can you give a small code snippet demonstrating the issue? Thanks!

[realdadfish]

I'm not sure if this is related, but this code snippet does not provoke an error in KtLint, which it should:

class Foo {
    private fun doBar(): Int =
        if (somethingIsTrue) {
            doThis()
    } else {
        doThat()
    }
    ...
}

Notice how the indentation of the else block is not following the one of the if block. This is with ktlint 0.34.2 btw. and was also the case with 0.31 and earlier versions before.

[alejandrorosas]

@realdadfish I think he means this case:

class Foo {
    private fun doBar() {
            doThis()
    }

    private fun doFoo() {
        doThis()
    }
    ...
}

So this case it succeeds when linting although there's an extra tab on the doBar() method.

[ElenaSpb]

additionally - if package in class is not the same as location - it does not show such errors..

[ggajews]

@ElenaSpb I run into the same issue. How did you change the configuration to fix this?

[Tapchicoma]

@ggajews is it happening for you as well?

[ElenaSpb]

execuse me - I thought I leave previos comment (about fixing with configuration) in another issue.
this 2 bugs which I describe are still reproduced
may be there were made some changes
but in
ktlint "com.github.shyiko:ktlint:0.31.0"
it is reproduces

[ggajews]

@Tapchicoma yes, we are using spaces for formatting, and if I add a random tab in the line, ktlint does not report it.

[paul-dingemans]

Problem is that lines that are properly indented at the correct level but are using the wrong indentation style (tabs instead of space or vice versa) are not autocorrected. In the example of this issue, only the the improperly indented lines were fixed. PR is on its way.