experimental:annotation crash during formatting

[shashachu]

Observed Behavior

com.pinterest.ktlint.core.RuleExecutionException: java.lang.IndexOutOfBoundsException: Wrong offset: 29566. Should be in range: [0, 29472]
	at com.pinterest.ktlint.core.KtLint$format$2.invoke(KtLint.kt:386)
	at com.pinterest.ktlint.core.KtLint$format$2.invoke(KtLint.kt:43)
	at com.pinterest.ktlint.core.KtLint$visitor$2$1.invoke(KtLint.kt:248)
	at com.pinterest.ktlint.core.KtLint$visitor$2$1.invoke(KtLint.kt:43)
	at com.pinterest.ktlint.core.KtLint.visit(KtLint.kt:574)
	at com.pinterest.ktlint.core.KtLint.visit(KtLint.kt:575)
	at com.pinterest.ktlint.core.KtLint.visit(KtLint.kt:575)
	at com.pinterest.ktlint.core.KtLint.visit(KtLint.kt:575)
	at com.pinterest.ktlint.core.KtLint.visit(KtLint.kt:575)
	at com.pinterest.ktlint.core.KtLint.visit(KtLint.kt:575)
	at com.pinterest.ktlint.core.KtLint.visit(KtLint.kt:575)
	at com.pinterest.ktlint.core.KtLint.access$visit(KtLint.kt:43)
	at com.pinterest.ktlint.core.KtLint$visitor$2.invoke(KtLint.kt:246)
	at com.pinterest.ktlint.core.KtLint$visitor$2.invoke(KtLint.kt:43)
	at com.pinterest.ktlint.core.KtLint.format(KtLint.kt:371)
	at com.pinterest.ktlint.internal.FileUtilsKt.formatFile(FileUtils.kt:79)
	at com.pinterest.ktlint.KtlintCommandLine.process(Main.kt:331)
	at com.pinterest.ktlint.KtlintCommandLine.access$process(Main.kt:116)
	at com.pinterest.ktlint.KtlintCommandLine$lintFiles$2$1.call(Main.kt:257)
	at com.pinterest.ktlint.KtlintCommandLine$lintFiles$2$1.call(Main.kt:116)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.IndexOutOfBoundsException: Wrong offset: 29566. Should be in range: [0, 29472]
	at org.jetbrains.kotlin.com.intellij.openapi.editor.impl.LineSet.findLineIndex(LineSet.java:178)
	at org.jetbrains.kotlin.com.intellij.openapi.editor.impl.DocumentImpl.getLineNumber(DocumentImpl.java:991)
	at com.pinterest.ktlint.core.ast.PackageKt.lineNumber(package.kt:235)
	at com.pinterest.ktlint.ruleset.experimental.AnnotationRule.visit(AnnotationRule.kt:149)
	at com.pinterest.ktlint.core.KtLint$format$2.invoke(KtLint.kt:376)

Steps to Reproduce

package a.b.c

class Test {
    fun bloop() {
        asdfadsf(asdfadsf, asdfasdf, asdfasdfasdfads,
        asdfasdf, asdfasdf, asdfasdf)
    }

    @Blah
    val test: Int
}

Your Environment

• Version of ktlint used: 0.38.1

Introduced in 4dda69b

[shashachu]

This appears to not play well with other rules (in this case parameter wrapping) that change the number of lines in the file.

[AdamMTGreenberg]

I can take this on and adapt it tonight

[AdamMTGreenberg]

Sorry for the delay - weekend got away from me, hoping to work on this tomorrow

[AdamMTGreenberg]

@shashachu when I add the base test provided, it does not seem to fail - please see: #880

I think the underlying issue is the code above as you pointed out AnnotationRule.visit has me a bit troubled and I think I'm trying to do too much in a single rule, so I feel as if the best path forward is most likely splitting the multi-line rule and auto fix out into its own rule.

[shashachu]

Should be fixed by #881