-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
experimental:annotation crash during formatting #868
Comments
This appears to not play well with other rules (in this case parameter wrapping) that change the number of lines in the file. |
I can take this on and adapt it tonight |
Sorry for the delay - weekend got away from me, hoping to work on this tomorrow |
@shashachu when I add the base test provided, it does not seem to fail - please see: #880 I think the underlying issue is the code above as you pointed out |
* Moving the multi line fixes out to a seperate rule so that we can ensure we aren't doing strange stuff cloning nodes, etc * Move all the multi line tests to the new rule class to ensure the rule is adapted * Fixing the unit tests since there was a missing commit somehow in the historical section * Add the multiline to the RuleSetProvider * Linting all at once * Fixing lint issues * We are able to achieve the same results without the line number checks * Accidental line delete * Updated the naming to match the suggestions from code review: "Maybe a more descriptive name would be 'annotation-spacing' or something similar?" * Unsure how this passed successfully before, but adapting it to make sure it is only triggering the correct errors for the test and not something with the annotation line rule
* Added rule ids into README (pinterest#879) * Added changelog entry for pinterest#868
Should be fixed by #881 |
Observed Behavior
Steps to Reproduce
Your Environment
Introduced in 4dda69b
The text was updated successfully, but these errors were encountered: