Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NoConsecutiveBlankLinesRule: report blank line between class name and primary constructor #1005

Merged
merged 1 commit into from
Dec 12, 2020
Merged

NoConsecutiveBlankLinesRule: report blank line between class name and primary constructor #1005

merged 1 commit into from
Dec 12, 2020

Conversation

t-kameyama
Copy link
Contributor

Fixes #1004

marco89nish
marco89nish approved these changes Dec 11, 2020
View reviewed changes
Copy link

@marco89nish marco89nish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romtsn romtsn merged commit e33adfc into pinterest:master Dec 12, 2020
@t-kameyama t-kameyama deleted the issue_1004 branch December 12, 2020 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco89nish marco89nish marco89nish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty line before primary constructor is not reported and formated-out
3 participants
@t-kameyama @marco89nish @romtsn