Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive with eol comment (annotation-spacing) #1168

Merged
merged 2 commits into from
Jun 22, 2021

Conversation

t-kameyama
Copy link
Contributor

Description

Fixes #1124

Checklist

  • tests are added
  • CHANGELOG.md is updated

@shashachu
Copy link
Contributor

thanks for the PR, @t-kameyama. We're having trouble with the dependency verification so I'm going to temporarily disable it. Once I've landed that you can rebase and hopefully your build should pass.

@Tapchicoma Tapchicoma merged commit 2c0bfdd into pinterest:master Jun 22, 2021
@t-kameyama t-kameyama deleted the issue_1124 branch June 22, 2021 21:34
t-kameyama added a commit to t-kameyama/ktlint that referenced this pull request Jun 23, 2021
@t-kameyama t-kameyama mentioned this pull request Jun 23, 2021
2 tasks
Tapchicoma pushed a commit that referenced this pull request Jun 23, 2021
romtsn pushed a commit to paul-dingemans/ktlint that referenced this pull request Aug 8, 2021
…#1168)

Co-authored-by: Yahor Berdnikau <egorr.berd@gmail.com>
romtsn pushed a commit to paul-dingemans/ktlint that referenced this pull request Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

annotation-spacing dies on comments
3 participants