Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false negative in when conditions (chain-wrapping) #1181

Merged
merged 1 commit into from
Jul 15, 2021
Merged

Fix false negative in when conditions (chain-wrapping) #1181

merged 1 commit into from
Jul 15, 2021

Conversation

t-kameyama
Copy link
Contributor

Description

Fixes #1130

Checklist

  • tests are added
  • CHANGELOG.md is updated

Tapchicoma
Tapchicoma approved these changes Jul 15, 2021
View reviewed changes
Copy link
Collaborator

@Tapchicoma Tapchicoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Tapchicoma Tapchicoma merged commit a0a1462 into pinterest:master Jul 15, 2021
@t-kameyama t-kameyama deleted the issue_1130 branch July 15, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tapchicoma Tapchicoma Tapchicoma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Line must not begin with "&&" rule not working in when conditions
2 participants
@t-kameyama @Tapchicoma