Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Java 16+ CLI #1359

Merged
merged 2 commits into from
Feb 8, 2022
Merged

Fix for Java 16+ CLI #1359

merged 2 commits into from
Feb 8, 2022

Conversation

shashachu
Copy link
Contributor

@shashachu shashachu commented Feb 2, 2022 •
edited
Loading

Description

Conditionally add --add-opens flag based on java version

Fixes #1195

Checklist

  • [ x ] CHANGELOG.md is updated

@paul-dingemans paul-dingemans added this to the 0.44.0 milestone Feb 3, 2022
paul-dingemans
paul-dingemans reviewed Feb 3, 2022
View reviewed changes
Copy link
Collaborator

@paul-dingemans paul-dingemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will work. Unfortunately, I am not able to reproduce any of the Java16 issues anymore on my local machine with the current version of ktlint with java 16 nor 17. So I can not test whether your fix solve those problems.

ktlint/build.gradle Show resolved Hide resolved
@paul-dingemans paul-dingemans mentioned this pull request Feb 5, 2022
Closed
@shashachu shashachu merged commit f72be11 into pinterest:master Feb 8, 2022
@shashachu shashachu mentioned this pull request Feb 8, 2022
Closed
@orchestr7 orchestr7 mentioned this pull request Feb 11, 2022
Closed
@mskonovalov mskonovalov mentioned this pull request Apr 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-dingemans paul-dingemans paul-dingemans left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.44.0
Development

Successfully merging this pull request may close these issues.

ktlint fails on Java 16+
2 participants
@shashachu @paul-dingemans