Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File with single toplevel extension function should only adhere to PascalConvention #1528

Merged

Conversation

paul-dingemans
Copy link
Collaborator

@paul-dingemans paul-dingemans commented Jun 27, 2022

Description

Closes #1521

Checklist

  • PR description added
  • tests are added
  • CHANGELOG.md is updated

In case of adding a new rule:

  • README.md is updated
  • Rule has been applied on Ktlint itself and violations are fixed

…plus name of an extension function when it is the only top level declaration in a file

Closes pinterest#1521
…ver contains a nullable type and or a generic type. The implementation is a bit crude by just removing "?", "<" and ">"" from the TYPE_REFERENCE.
…pe receiver contains a nullable type and or a generic type. The implementation is a bit crude by just removing "?", "<" and ">"" from the TYPE_REFERENCE."

This reverts commit 9de014c.
…r class plus name of an extension function when it is the only top level declaration in a file"

This reverts commit 31cad30.
…er that function but only has to adhere to the PascalCase convention
@paul-dingemans paul-dingemans changed the title Filename for single toplevel extension function File with single toplevel extension function should only adhere to PascalConvention Jul 17, 2022
@paul-dingemans paul-dingemans added this to the 0.47.0 milestone Jul 17, 2022
# Conflicts:
#	CHANGELOG.md
#	ktlint-ruleset-standard/src/main/kotlin/com/pinterest/ktlint/ruleset/standard/FilenameRule.kt
@paul-dingemans paul-dingemans merged commit 7abe7da into pinterest:master Jul 18, 2022
@paul-dingemans paul-dingemans deleted the 1521-filename-extension-function branch July 18, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow naming file with single extension method after the target of the extension
1 participant