-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split TrailingCommaRule #1555
Split TrailingCommaRule #1555
Conversation
.../src/main/kotlin/com/pinterest/ktlint/ruleset/standard/TrailingCommaOnDeclarationSiteRule.kt
Outdated
Show resolved
Hide resolved
...eset-standard/src/test/kotlin/com/pinterest/ktlint/ruleset/standard/TrailingCommaRuleTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tnx for the contribution. Please address the review remarks.
...et-standard/src/main/kotlin/com/pinterest/ktlint/ruleset/standard/StandardRuleSetProvider.kt
Outdated
Show resolved
Hide resolved
...tandard/src/main/kotlin/com/pinterest/ktlint/ruleset/standard/TrailingCommaOnCallSiteRule.kt
Show resolved
Hide resolved
.../src/main/kotlin/com/pinterest/ktlint/ruleset/standard/TrailingCommaOnDeclarationSiteRule.kt
Show resolved
Hide resolved
.../src/main/kotlin/com/pinterest/ktlint/ruleset/standard/TrailingCommaOnDeclarationSiteRule.kt
Outdated
Show resolved
Hide resolved
...tlin/com/pinterest/ktlint/ruleset/standard/internal/trailingcomma/TrailingCommaExtensions.kt
Outdated
Show resolved
Hide resolved
...in/kotlin/com/pinterest/ktlint/ruleset/standard/internal/trailingcomma/TrailingCommaState.kt
Outdated
Show resolved
Hide resolved
Also the documentation pages (not yet formally announced) need to be updated. See file https://github.com/pinterest/ktlint/blob/master/docs/rules/standard.md New documentation has been released and changed in your branch as well. Can you please update new docs, if not yet done so? |
I just bumped into test |
I am not sure if this is intended for this PR - All the CI checks are passing for me this time with the refactoring as suggested. |
Sorry, this remark was meant for the PR regarding the enums and trailing comma's. |
@chao2zhang The Trailing comma in enum PR has been merged. Changes are non-trivial, so please be careful with merging changes to your branch. |
9e227c3
to
35bd5d4
Compare
- fix broken visitor-modifier in MaxLineLengthRule
Fix #1552
Description
Split TrailingCommaRule into
OnDeclarationSite
andOnCallSite
Checklist
CHANGELOG.md
is updatedIn case of adding a new rule:
README.md
is updated