-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve support of default editorconfig properties #1580
Improve support of default editorconfig properties #1580
Commits on Aug 13, 2022
-
Improve support of default editorconfig properties
Deprecate ExperimentalParams.editorConfigDefaults in favor of new parameter ExperimentalParams.editorConfigDefaults. When used in the old implementation this resulted in ignoring all ".editorconfig" files on the path to the file. The new implementation uses properties from the "editorConfigDefaults" parameter only when no ".editorconfig" files on the path to the file supplies this property for the filepath. Closes pinterest#1551 API consumers can easily create the EditConfigDefaults by calling "EditConfigDefaults.load(path)" or creating it programmatically. The CLI still supports the "--editorconfig=" option but has improved support. The path given can be either be a path to file or directory. In case of a directory path, it is expected that the directory does contain a file with name ".editorconfig". In of a file path, any valid file name is accepted. The path can be relative or absolute. Depending on the OS, the "~" at the start of the path is accepted as well. BaseCLITest no longer always waits 3 seconds for completion of the asynchronous process. Once the process is started, it checks every 100 ms whether the process is still alive (e.g. is running) and stops polling otherwise resulting in better performance (most notable on local machine). The maximum duration of the CLI test has been increased to 10 seconds.
Configuration menu - View commit details
-
Copy full SHA for 54f8194 - Browse repository at this point
Copy the full SHA 54f8194View commit details -
Disable test on Windows as filename can not start or end with a space…
… (automatically trimmed)
Configuration menu - View commit details
-
Copy full SHA for 28b90fb - Browse repository at this point
Copy the full SHA 28b90fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 236e611 - Browse repository at this point
Copy the full SHA 236e611View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b2ee55 - Browse repository at this point
Copy the full SHA 8b2ee55View commit details
Commits on Aug 14, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 757be14 - Browse repository at this point
Copy the full SHA 757be14View commit details -
Configuration menu - View commit details
-
Copy full SHA for 669414f - Browse repository at this point
Copy the full SHA 669414fView commit details -
Merge remote-tracking branch 'origin/1551-editorconfig-path-cli' into…
… 1551-editorconfig-path-cli
Configuration menu - View commit details
-
Copy full SHA for 9552ad4 - Browse repository at this point
Copy the full SHA 9552ad4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 547f765 - Browse repository at this point
Copy the full SHA 547f765View commit details
Commits on Aug 16, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 63fe43c - Browse repository at this point
Copy the full SHA 63fe43cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 42454e2 - Browse repository at this point
Copy the full SHA 42454e2View commit details
Commits on Aug 17, 2022
-
Merge branch 'master' into 1551-editorconfig-path-cli
# Conflicts: # CHANGELOG.md # ktlint-core/src/main/kotlin/com/pinterest/ktlint/core/internal/EditorConfigLoader.kt # ktlint-core/src/main/kotlin/com/pinterest/ktlint/core/internal/PreparedCode.kt # ktlint-core/src/main/kotlin/com/pinterest/ktlint/core/internal/ThreadSafeEditorConfigCache.kt # ktlint-core/src/test/kotlin/com/pinterest/ktlint/core/internal/EditorConfigLoaderTest.kt # ktlint/src/main/kotlin/com/pinterest/ktlint/internal/KtlintCommandLine.kt
Configuration menu - View commit details
-
Copy full SHA for fdf06dd - Browse repository at this point
Copy the full SHA fdf06ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 211af20 - Browse repository at this point
Copy the full SHA 211af20View commit details